1631644 - Add Element::HasGridFragments() for use in the devtools

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Emily McDonough [:alaskanemily]]

Several places in the devtools getGridFragments() is called only to test if there are any fragments, not to actually examine them. We can add a cheaper function which just tests for the existence of fragments and change these locations to use it.

This will be cheaper than calling Element::GetGridFragments as it will not need to construct an entire array of results.

Comment 1

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1631644 - Add Element::HasGridFragments() and use it in appropriate locations in devtools

This is cheaper than calling Element::GetGridFragments as it does not need to
to construct an entire array of results. Most uses of GetGridFragments in the
devtools are only testing for the existence of grid fragments, and can be
changed to this cheaper method instead.

Comment 2

[Cristian Brindusan [:cbrindusan]]

Your patch failed to land due to this error. :[:alaskanemily] can you please take a look and make the necessary modifications?

remote: ******************************* ERROR *******************************
remote: Changeset 26fbd977710d alters WebIDL file(s) without DOM peer review:
remote: dom/webidl/Element.webidl
remote:
remote: Please, request review from the #webidl reviewer group or either:
remote: - Andrea Marchesini (:baku)
remote: - Andreas Farre (:farre)
remote: - Andrew McCreight (:mccr8)
remote: - Bobby Holley (:bholley)
remote: - Ehsan Akhgari (:ehsan)
remote: - Emilio Cobos (:emilio)
remote: - Henri Sivonen (:hsivonen)
remote: - Nika Layzell (:mystor)
remote: - Olli Pettay (:smaug)
remote: - Peter Van der Beken (:peterv)
remote: *********************************************************************

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ddd02060e42
Add Element::HasGridFragments() and use it in appropriate locations in devtools r=bradwerth,emilio

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9ddd02060e42

Comment 5

[Razvan Caliman [:rcaliman]]

This is great. Thank you, Emily!