1631657 - Account avatar goes square when the account is in a bad state

Status: NEW

(Firefox :: Firefox Accounts, defect, P2)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: reconnect.gif

As reported by Vlad.

What I think is happening is that this CSS rule makes the icon round only when the user is in a "signedin" state. This works fine in the normal flows, as this is the only state where we have a user avatar.

However, it doesn't work when the account state was good, but then goes bad - we revert to a square avatar, but still show the user's avatar.

Ryan: I assume keeping the user's avatar in this state is desirable? If so, the fix is probably to have a different attribute which is specific to the avatar state.

Also, how much does this bother you? (ie, what priority should it be?)

Comment 1

[Vlad Filippov (:vladikoff)]

Thank you for reporting the bug Mark, I didn't get a chance because I was working on something else at the time. If someone can reproduce this on their Nightly or Stable that would be useful!

Comment 2

[Ryan Feeley [:rfeeley]]

I believe the correct thing to do is to revert to the default icon with the warning triangle as indicated on the righthand column https://mozilla.invisionapp.com/share/V6ST9IFJMXP#/screens

Comment 3

[Wil Clouser [:clouserw]]

-> Vijay, but it's not a high priority. Good find, Mark!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:markh, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:markh, could you have a look please?

For more information, please visit auto_nag documentation.