Closed Bug 1631658 Opened 5 years ago Closed 5 years ago

Change RSExperimentLoader to use .targeting for filtering

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

Attachments

(1 file)

Bug 1631658 - Change RSExperimentLoader to use .targeting for filtering
47 bytes, text/x-phabricator-request
Details | Review

Right now the filter_expression defined on Remote Settings experiment recipes is being processed by both RemoteSettings and ASRouterTargeting (via the RemoteSettingsExperimentLoader). This isn't ideal – we should probably rename this field to prevent conflicts or stop using ASRouterTargeting for filtering.

Summary: filter_expression is evaluated by both RemoteSettingsExperimentLoader and RemoteSettings → Change RSExperimentLoader to user .targeting for filtering
Summary: Change RSExperimentLoader to user .targeting for filtering → Change RSExperimentLoader to use .targeting for filtering
Assignee: nobody → khudson
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by khudson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f155b9755f25 Change RSExperimentLoader to use .targeting for filtering r=andreio

https://hg.mozilla.org/mozilla-central/rev/f155b9755f25

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: