1631687 - Remove per-primitive surface inflation

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1631687 - Remove per-primitive surface inflation

It's no longer required, since we inflate the picture and
surface rects directly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c50d92db013
Remove per-primitive surface inflation r=kvark

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 2c50d92db013 (bug 1631687) for reftests failures on default-subregion.svg and mix-blend-mode-and-filter.svg

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=9ddd02060e420b5496829ec80819a3de09c0b3da&searchStr=android%2Cgeckoview-reftest-e10s&tochange=84855eefe4c47deb80d3a9693f5aa7c9f5b9f03c&selectedJob=298696301

Backout link: https://hg.mozilla.org/integration/autoland/rev/84855eefe4c47deb80d3a9693f5aa7c9f5b9f03c

Failures logs: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298696301&repo=autoland&lineNumber=3222

[task 2020-04-21T21:25:03.018Z] 21:25:02     INFO -  REFTEST TEST-START | layout/reftests/svg/filters/svg-filter-chains/default-subregion.svg == layout/reftests/svg/filters/svg-filter-chains/default-subregion-ref.svg
[task 2020-04-21T21:25:03.018Z] 21:25:02     INFO -  REFTEST TEST-LOAD | http://10.7.205.156:8854/tests/layout/reftests/svg/filters/svg-filter-chains/default-subregion.svg | 283 / 1750 (16%)
[task 2020-04-21T21:25:03.018Z] 21:25:02     INFO -  REFTEST TEST-LOAD | http://10.7.205.156:8854/tests/layout/reftests/svg/filters/svg-filter-chains/default-subregion-ref.svg | 283 / 1750 (16%)
[task 2020-04-21T21:25:03.018Z] 21:25:02     INFO -  REFTEST INFO | REFTEST fuzzy test (3, 17552) <= (5, 20288) <= (5, 20160)
[task 2020-04-21T21:25:03.018Z] 21:25:02  WARNING -  REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/svg/filters/svg-filter-chains/default-subregion.svg == layout/reftests/svg/filters/svg-filter-chains/default-subregion-ref.svg | image comparison, max difference: 5, number of differing pixels: 20288
[task 2020-04-21T21:25:03.018Z] 21:25:02     INFO -  REFTEST   IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAA...
[task 2020-04-21T21:25:03.018Z] 21:25:03     INFO -  REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAy...
[task 2020-04-21T21:25:03.018Z] 21:25:03     INFO -  REFTEST TEST-END | layout/reftests/svg/filters/svg-filter-chains/default-subregion.svg == layout/reftests/svg/filters/svg-filter-chains/default-subregion-ref.svg

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298696201&repo=autoland&lineNumber=11436

[task 2020-04-21T21:28:30.616Z] 21:28:30     INFO -  REFTEST TEST-START | layout/reftests/css-blending/mix-blend-mode-and-filter.svg == layout/reftests/css-blending/mix-blend-mode-and-filter-ref.svg
[task 2020-04-21T21:28:30.616Z] 21:28:30     INFO -  REFTEST TEST-LOAD | http://10.7.205.240:8854/tests/layout/reftests/css-blending/mix-blend-mode-and-filter.svg | 1770 / 1797 (98%)
[task 2020-04-21T21:28:30.616Z] 21:28:30     INFO -  REFTEST TEST-LOAD | http://10.7.205.240:8854/tests/layout/reftests/css-blending/mix-blend-mode-and-filter-ref.svg | 1770 / 1797 (98%)
[task 2020-04-21T21:28:30.616Z] 21:28:30  WARNING -  REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/css-blending/mix-blend-mode-and-filter.svg == layout/reftests/css-blending/mix-blend-mode-and-filter-ref.svg | image comparison, max difference: 3, number of differing pixels: 64
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST   IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAP...
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAA...
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: START http://10.7.205.240:8854/tests/layout/reftests/css-blending/mix-blend-mode-and-filter.svg
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: RecordResult fired
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: START http://10.7.205.240:8854/tests/layout/reftests/css-blending/mix-blend-mode-and-filter-ref.svg
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: [CONTENT] FlushRendering generated paint for window http://10.7.205.240:8854/tests/layout/reftests/css-blending/mix-blend-mode-and-filter-ref.svg
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST INFO | Saved log: RecordResult fired
[task 2020-04-21T21:28:30.617Z] 21:28:30     INFO -  REFTEST TEST-END | layout/reftests/css-blending/mix-blend-mode-and-filter.svg == layout/reftests/css-blending/mix-blend-mode-and-filter-ref.svg

Comment 4

[Glenn Watson [:gw]]

I fixed up the issues in those reftests, but then I realized there is another issue with this patch. So I will need to re-work it before trying to land again.