Closed Bug 1631722 Opened 4 years ago Closed 4 years ago

Implement structured headers

Categories

(Core :: Networking, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: annevk, Assigned: undef1nd)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [necko-triaged][outreachy])

Attachments

(2 files, 1 obsolete file)

We have many new features that need support for https://httpwg.org/http-extensions/draft-ietf-httpbis-header-structure.html (also at https://tools.ietf.org/html/draft-ietf-httpbis-header-structure). Some older headers might also be able to reuse these parsers and accompanying data structures.

This is going to be our outreachy project for the summer.

Priority: -- → P3
Whiteboard: [necko-triaged][outreachy]
Assignee: nobody → yalyna.ts

Valentin, as of the dependency chain this bug is blocking bug 1613066 and thus bug 1619649. Is this really the case? Or should we link this to some follow-up work ?

Flags: needinfo?(valentin.gosu)

(In reply to Jens Stutte [:jstutte] from comment #2)

Valentin, as of the dependency chain this bug is blocking bug 1613066 and thus bug 1619649. Is this really the case? Or should we link this to some follow-up work ?

Some of the tests depend on having structured header support, but I think we decided we can ship without this?
We might need a separate bug for follow-up work.

Flags: needinfo?(valentin.gosu)

Indeed we did. Bug 1563480 tracks follow-up work. And bug 1626486 is already blocking that one.

Blocks: 1563480
No longer blocks: 1631748

Note that they recently renamed this to "Structured Field Values for HTTP" and it's in the RFC Editor queue so I assume that'll be the final name. We might want to make our code reflect that if it's still easy to change.

Thanks for the info. I will align the names with RFC.

Attachment #9160413 - Attachment description: Bug 1631722 - Vendor structured-headers crate,r=valentin → Bug 1631722 - Vendor sfv crate,r=valentin
Attachment #9163491 - Attachment is obsolete: true
Attachment #9160413 - Attachment is obsolete: true
Attachment #9163491 - Attachment is obsolete: false
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ed318dc1f3ae
Vendor sfv crate,r=valentin
https://hg.mozilla.org/integration/autoland/rev/b0b1c0fa93f9
Add wrapper for structured-headers crate,r=valentin
Flags: needinfo?(yalyna.ts)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e635eff6171b
Vendor sfv crate,r=valentin
https://hg.mozilla.org/integration/autoland/rev/580b7fe5c831
Add wrapper for structured-headers crate,r=valentin

Backed out 2 changesets (bug 1631722) for windows bpgo failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=QxHYsW2CSzeR3O35BVSj9A.0&searchStr=windows%2Cprofile-guided%2Coptimization%2Cbuilds&fromchange=840272088ab1ee282b937ee38d9dc9f95b4d54b1&tochange=421782dc83375fbef2f6cb3965885ce6a76f25fc

Backout link: https://hg.mozilla.org/integration/autoland/rev/421782dc83375fbef2f6cb3965885ce6a76f25fc

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312392417&repo=autoland&lineNumber=19370

...
[task 2020-08-07T13:27:39.489Z] 13:27:39     INFO -       Running `/builds/worker/workspace/obj-build/release/build/hashbrown-c324bdc365e7c555/build-script-build`
[task 2020-08-07T13:27:39.489Z] 13:27:39     INFO -  [hashbrown 0.7.2] cargo:rerun-if-changed=build.rs
[task 2020-08-07T13:27:39.489Z] 13:27:39     INFO -  [indexmap 1.4.0] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.490Z] 13:27:39     INFO -  [indexmap 1.4.0]
[task 2020-08-07T13:27:39.490Z] 13:27:39     INFO -  [hashbrown 0.7.2] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.490Z] 13:27:39     INFO -  [hashbrown 0.7.2]
[task 2020-08-07T13:27:39.490Z] 13:27:39    ERROR -  [indexmap 1.4.0] error: aborting due to previous error
[task 2020-08-07T13:27:39.490Z] 13:27:39     INFO -  [indexmap 1.4.0]
[task 2020-08-07T13:27:39.491Z] 13:27:39    ERROR -  [hashbrown 0.7.2] error: aborting due to previous error
[task 2020-08-07T13:27:39.491Z] 13:27:39     INFO -  [hashbrown 0.7.2]
[task 2020-08-07T13:27:39.491Z] 13:27:39     INFO -  [hashbrown 0.7.2] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.491Z] 13:27:39     INFO -  [hashbrown 0.7.2]
[task 2020-08-07T13:27:39.491Z] 13:27:39     INFO -  [indexmap 1.4.0] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.492Z] 13:27:39     INFO -  [indexmap 1.4.0]
[task 2020-08-07T13:27:39.492Z] 13:27:39    ERROR -  [indexmap 1.4.0] error: aborting due to previous error
[task 2020-08-07T13:27:39.492Z] 13:27:39     INFO -  [indexmap 1.4.0]
[task 2020-08-07T13:27:39.492Z] 13:27:39     INFO -  [indexmap 1.4.0] warning: autocfg could not probe for `std`
[task 2020-08-07T13:27:39.492Z] 13:27:39    ERROR -  [hashbrown 0.7.2] error: aborting due to previous error
[task 2020-08-07T13:27:39.492Z] 13:27:39     INFO -  [hashbrown 0.7.2]
[task 2020-08-07T13:27:39.493Z] 13:27:39     INFO -  [hashbrown 0.7.2] warning: autocfg could not probe for `std`
[task 2020-08-07T13:27:39.493Z] 13:27:39     INFO -  [hashbrown 0.7.2] cargo:rustc-cfg=has_extern_crate_alloc
[task 2020-08-07T13:27:39.493Z] 13:27:39     INFO -       Running `CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/third_party/rust/anyhow CARGO_PKG_AUTHORS='David Tolnay <dtolnay@gmail.com>' CARGO_PKG_DESCRIPTION='Flexible concrete Error type built on std::error::Error' CARGO_PKG_HOMEPAGE= CARGO_PKG_NAME=anyhow CARGO_PKG_REPOSITORY='https://github.com/dtolnay/anyhow' CARGO_PKG_VERSION=1.0.30 CARGO_PKG_VERSION_MAJOR=1 CARGO_PKG_VERSION_MINOR=0 CARGO_PKG_VERSION_PATCH=30 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/builds/worker/workspace/obj-build/release/deps:/builds/worker/fetches/rustc/lib' OUT_DIR=/builds/worker/workspace/obj-build/release/build/anyhow-d99b5ee6087cd298/out /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name anyhow --edition=2018 /builds/worker/checkouts/gecko/third_party/rust/anyhow/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=b7a6d66a389be9ca -C extra-filename=-b7a6d66a389be9ca --out-dir /builds/worker/workspace/obj-build/release/deps -C linker=/builds/worker/checkouts/gecko/build/cargo-host-linker -L dependency=/builds/worker/workspace/obj-build/release/deps --cap-lints warn`
[task 2020-08-07T13:27:39.493Z] 13:27:39     INFO -  [indexmap 1.4.0] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.493Z] 13:27:39     INFO -  [indexmap 1.4.0]
[task 2020-08-07T13:27:39.494Z] 13:27:39    ERROR -  [indexmap 1.4.0] error: aborting due to previous error
[task 2020-08-07T13:27:39.494Z] 13:27:39     INFO -  [indexmap 1.4.0]
[task 2020-08-07T13:27:39.494Z] 13:27:39     INFO -  [indexmap 1.4.0] cargo:rerun-if-changed=build.rs
...
Flags: needinfo?(yalyna.ts)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/24560593473e
Vendor sfv crate,r=valentin
https://hg.mozilla.org/integration/autoland/rev/6c52fb84d5c3
Add wrapper for structured-headers crate,r=valentin
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cfa1f8e3a900
Vendor sfv crate,r=valentin
https://hg.mozilla.org/integration/autoland/rev/203dd164f9ca
Add wrapper for structured-headers crate,r=valentin
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Flags: needinfo?(yalyna.ts)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: