Implement structured headers
Categories
(Core :: Networking, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: annevk, Assigned: undef1nd)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [necko-triaged][outreachy])
Attachments
(2 files, 1 obsolete file)
We have many new features that need support for https://httpwg.org/http-extensions/draft-ietf-httpbis-header-structure.html (also at https://tools.ietf.org/html/draft-ietf-httpbis-header-structure). Some older headers might also be able to reuse these parsers and accompanying data structures.
Comment 1•5 years ago
|
||
This is going to be our outreachy project for the summer.
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Valentin, as of the dependency chain this bug is blocking bug 1613066 and thus bug 1619649. Is this really the case? Or should we link this to some follow-up work ?
Comment 3•4 years ago
|
||
(In reply to Jens Stutte [:jstutte] from comment #2)
Valentin, as of the dependency chain this bug is blocking bug 1613066 and thus bug 1619649. Is this really the case? Or should we link this to some follow-up work ?
Some of the tests depend on having structured header support, but I think we decided we can ship without this?
We might need a separate bug for follow-up work.
Reporter | ||
Comment 4•4 years ago
|
||
Indeed we did. Bug 1563480 tracks follow-up work. And bug 1626486 is already blocking that one.
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Reporter | ||
Comment 6•4 years ago
|
||
Note that they recently renamed this to "Structured Field Values for HTTP" and it's in the RFC Editor queue so I assume that'll be the final name. We might want to make our code reflect that if it's still easy to change.
Assignee | ||
Comment 7•4 years ago
|
||
Thanks for the info. I will align the names with RFC.
Assignee | ||
Comment 8•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 9•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ed318dc1f3ae Vendor sfv crate,r=valentin https://hg.mozilla.org/integration/autoland/rev/b0b1c0fa93f9 Add wrapper for structured-headers crate,r=valentin
Comment 11•4 years ago
|
||
Backed out for causing build bustages.
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=312271397&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/6177d744aed730c827f51488074fe04ff83aa4df
Assignee | ||
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e635eff6171b Vendor sfv crate,r=valentin https://hg.mozilla.org/integration/autoland/rev/580b7fe5c831 Add wrapper for structured-headers crate,r=valentin
Comment 13•4 years ago
|
||
Backed out 2 changesets (bug 1631722) for windows bpgo failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/421782dc83375fbef2f6cb3965885ce6a76f25fc
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312392417&repo=autoland&lineNumber=19370
...
[task 2020-08-07T13:27:39.489Z] 13:27:39 INFO - Running `/builds/worker/workspace/obj-build/release/build/hashbrown-c324bdc365e7c555/build-script-build`
[task 2020-08-07T13:27:39.489Z] 13:27:39 INFO - [hashbrown 0.7.2] cargo:rerun-if-changed=build.rs
[task 2020-08-07T13:27:39.489Z] 13:27:39 INFO - [indexmap 1.4.0] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.490Z] 13:27:39 INFO - [indexmap 1.4.0]
[task 2020-08-07T13:27:39.490Z] 13:27:39 INFO - [hashbrown 0.7.2] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.490Z] 13:27:39 INFO - [hashbrown 0.7.2]
[task 2020-08-07T13:27:39.490Z] 13:27:39 ERROR - [indexmap 1.4.0] error: aborting due to previous error
[task 2020-08-07T13:27:39.490Z] 13:27:39 INFO - [indexmap 1.4.0]
[task 2020-08-07T13:27:39.491Z] 13:27:39 ERROR - [hashbrown 0.7.2] error: aborting due to previous error
[task 2020-08-07T13:27:39.491Z] 13:27:39 INFO - [hashbrown 0.7.2]
[task 2020-08-07T13:27:39.491Z] 13:27:39 INFO - [hashbrown 0.7.2] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.491Z] 13:27:39 INFO - [hashbrown 0.7.2]
[task 2020-08-07T13:27:39.491Z] 13:27:39 INFO - [indexmap 1.4.0] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.492Z] 13:27:39 INFO - [indexmap 1.4.0]
[task 2020-08-07T13:27:39.492Z] 13:27:39 ERROR - [indexmap 1.4.0] error: aborting due to previous error
[task 2020-08-07T13:27:39.492Z] 13:27:39 INFO - [indexmap 1.4.0]
[task 2020-08-07T13:27:39.492Z] 13:27:39 INFO - [indexmap 1.4.0] warning: autocfg could not probe for `std`
[task 2020-08-07T13:27:39.492Z] 13:27:39 ERROR - [hashbrown 0.7.2] error: aborting due to previous error
[task 2020-08-07T13:27:39.492Z] 13:27:39 INFO - [hashbrown 0.7.2]
[task 2020-08-07T13:27:39.493Z] 13:27:39 INFO - [hashbrown 0.7.2] warning: autocfg could not probe for `std`
[task 2020-08-07T13:27:39.493Z] 13:27:39 INFO - [hashbrown 0.7.2] cargo:rustc-cfg=has_extern_crate_alloc
[task 2020-08-07T13:27:39.493Z] 13:27:39 INFO - Running `CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/third_party/rust/anyhow CARGO_PKG_AUTHORS='David Tolnay <dtolnay@gmail.com>' CARGO_PKG_DESCRIPTION='Flexible concrete Error type built on std::error::Error' CARGO_PKG_HOMEPAGE= CARGO_PKG_NAME=anyhow CARGO_PKG_REPOSITORY='https://github.com/dtolnay/anyhow' CARGO_PKG_VERSION=1.0.30 CARGO_PKG_VERSION_MAJOR=1 CARGO_PKG_VERSION_MINOR=0 CARGO_PKG_VERSION_PATCH=30 CARGO_PKG_VERSION_PRE= LD_LIBRARY_PATH='/builds/worker/workspace/obj-build/release/deps:/builds/worker/fetches/rustc/lib' OUT_DIR=/builds/worker/workspace/obj-build/release/build/anyhow-d99b5ee6087cd298/out /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name anyhow --edition=2018 /builds/worker/checkouts/gecko/third_party/rust/anyhow/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 --cfg 'feature="default"' --cfg 'feature="std"' -C metadata=b7a6d66a389be9ca -C extra-filename=-b7a6d66a389be9ca --out-dir /builds/worker/workspace/obj-build/release/deps -C linker=/builds/worker/checkouts/gecko/build/cargo-host-linker -L dependency=/builds/worker/workspace/obj-build/release/deps --cap-lints warn`
[task 2020-08-07T13:27:39.493Z] 13:27:39 INFO - [indexmap 1.4.0] error: Profile-guided optimization does not yet work in conjunction with `-Cpanic=unwind` on Windows when targeting MSVC. See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for more information.
[task 2020-08-07T13:27:39.493Z] 13:27:39 INFO - [indexmap 1.4.0]
[task 2020-08-07T13:27:39.494Z] 13:27:39 ERROR - [indexmap 1.4.0] error: aborting due to previous error
[task 2020-08-07T13:27:39.494Z] 13:27:39 INFO - [indexmap 1.4.0]
[task 2020-08-07T13:27:39.494Z] 13:27:39 INFO - [indexmap 1.4.0] cargo:rerun-if-changed=build.rs
...
Comment 14•4 years ago
|
||
The following seems to start with the backed out changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312398062&repo=autoland&lineNumber=2294
Comment 15•4 years ago
|
||
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/24560593473e Vendor sfv crate,r=valentin https://hg.mozilla.org/integration/autoland/rev/6c52fb84d5c3 Add wrapper for structured-headers crate,r=valentin
Comment 16•4 years ago
|
||
Backed out 2 changesets (bug 1631722) for xpcshell failures at test_trr_cname_chain.js.
https://hg.mozilla.org/integration/autoland/rev/fad66448e049eb8fcebe1b56d172d3b1c61ed6e8
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312781876&repo=autoland&lineNumber=2433
Comment 17•4 years ago
|
||
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/cfa1f8e3a900 Vendor sfv crate,r=valentin https://hg.mozilla.org/integration/autoland/rev/203dd164f9ca Add wrapper for structured-headers crate,r=valentin
Comment 18•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cfa1f8e3a900
https://hg.mozilla.org/mozilla-central/rev/203dd164f9ca
Assignee | ||
Updated•4 years ago
|
Description
•