1631750 - Detect + reset modified `security.tls13` prefs from the no_cypher_overlap certerror page

Status: RESOLVED FIXED

(Firefox :: Security, defect, P3)

Description

[:Gijs (he/him)]

Looks like this should be easy enough to do by adding the root to https://searchfox.org/mozilla-central/source/browser/actors/NetErrorParent.jsm#20 and updating the test.

Comment 1

[Johann Hofmann [:johannh]]

Alex, would you like to take this bug?

Comment 2

[Obayagbona Uwagbae Alexander]

Yes, I'd need a bit more info though

Comment 3

[Johann Hofmann [:johannh]]

So the background is that we have some code that will check for modified preferences if the user encounters a network error page and asks the user if they would like to reset them, on the chance that this will help restore the connection. We would like to add a few more prefs, specifically those beginning with security.tls13..

Even though it's short comment 0 kind of summarizes the task well IMO, you need to add security.tls13. to that list and here https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/browser/base/content/test/about/browser_aboutNetError.js#11 and ensuring that the test still passes (and ideally checking manually that this works as expected).

Thanks!

Comment 4

[Obayagbona Uwagbae Alexander]

Thank you for the detailed explanation.

Comment 5

[Obayagbona Uwagbae Alexander]

Attachment: Bug 1631750 - Detect + reset modified `security.tls13` prefs from the no_cypher_overlap certerror page. r=johannh

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd5820819c9e
Detect + reset modified `security.tls13` prefs from the no_cypher_overlap certerror page. r=johannh

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/dd5820819c9e