Closed Bug 1631750 Opened 4 months ago Closed 3 months ago

Detect + reset modified `security.tls13` prefs from the no_cypher_overlap certerror page

Categories

(Firefox :: Security, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 77
Tracking Status
firefox77 --- fixed

People

(Reporter: Gijs, Assigned: uwaobayagbona)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Looks like this should be easy enough to do by adding the root to https://searchfox.org/mozilla-central/source/browser/actors/NetErrorParent.jsm#20 and updating the test.

Alex, would you like to take this bug?

Flags: needinfo?(uwaobayagbona)
Priority: -- → P3

Yes, I'd need a bit more info though

Flags: needinfo?(uwaobayagbona)

So the background is that we have some code that will check for modified preferences if the user encounters a network error page and asks the user if they would like to reset them, on the chance that this will help restore the connection. We would like to add a few more prefs, specifically those beginning with security.tls13..

Even though it's short comment 0 kind of summarizes the task well IMO, you need to add security.tls13. to that list and here https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/browser/base/content/test/about/browser_aboutNetError.js#11 and ensuring that the test still passes (and ideally checking manually that this works as expected).

Thanks!

Assignee: nobody → uwaobayagbona
Status: NEW → ASSIGNED

Thank you for the detailed explanation.

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd5820819c9e
Detect + reset modified `security.tls13` prefs from the no_cypher_overlap certerror page. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.