1631790 - DoH: Make the doorhanger text TRR-provider-agnostic.

Status: RESOLVED FIXED

(Firefox :: Security, task, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Since we're going to ship multiple providers with automatic selection, we should avoid mentioning Cloudflare or any other provider explicitly in the consent doorhanger text.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1631790 - DoH: Make the doorhanger text TRR-provider-agnostic. r=flod!,valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5444a9d7d457
DoH: Make the doorhanger text TRR-provider-agnostic. r=valentin,flod

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5444a9d7d457

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9142049 [details]
Bug 1631790 - DoH: Make the doorhanger text TRR-provider-agnostic. r=flod!,valentin

Beta/Release Uplift Approval Request

• User impact if declined: The explicit mention of Cloudflare in the DoH consent doorhanger copy is blocking us from shipping multiple-TRRs with automatic selection to our users. This string change will enable us to choose the best TRR for each client. We'd like to uplift this so that we can unpause our rollout.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just changes some strings and updates the string ID in code. All locales are covered already - translations were done in Github.
• String changes made/needed: The main DoH doorhanger copy was updated in this patch (for all supported locales).

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9142049 [details]
Bug 1631790 - DoH: Make the doorhanger text TRR-provider-agnostic. r=flod!,valentin

Text-only change offering clearer text in the TRR dropdown. Approved for 76.0b8.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9d109d011aaf