Closed Bug 1631790 Opened 4 months ago Closed 4 months ago

DoH: Make the doorhanger text TRR-provider-agnostic.

Categories

(Firefox :: Security, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 77
Tracking Status
firefox76 + fixed
firefox77 + fixed

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 file)

Since we're going to ship multiple providers with automatic selection, we should avoid mentioning Cloudflare or any other provider explicitly in the consent doorhanger text.

Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5444a9d7d457
DoH: Make the doorhanger text TRR-provider-agnostic. r=valentin,flod
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

Comment on attachment 9142049 [details]
Bug 1631790 - DoH: Make the doorhanger text TRR-provider-agnostic. r=flod!,valentin

Beta/Release Uplift Approval Request

  • User impact if declined: The explicit mention of Cloudflare in the DoH consent doorhanger copy is blocking us from shipping multiple-TRRs with automatic selection to our users. This string change will enable us to choose the best TRR for each client. We'd like to uplift this so that we can unpause our rollout.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This just changes some strings and updates the string ID in code. All locales are covered already - translations were done in Github.
  • String changes made/needed: The main DoH doorhanger copy was updated in this patch (for all supported locales).
Attachment #9142049 - Flags: approval-mozilla-beta?

Comment on attachment 9142049 [details]
Bug 1631790 - DoH: Make the doorhanger text TRR-provider-agnostic. r=flod!,valentin

Text-only change offering clearer text in the TRR dropdown. Approved for 76.0b8.

Attachment #9142049 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.