1631822 - Choose fastest TRR as measured by TRRPerformance.jsm as default DoH provider (dry-run)

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

1. Extend TRRPerformance API to expose the fastest provider.
2. Store this in a pref and send telemetry
3. In a future release, commit this chosen value as the selected TRR.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1631822 - Move TRR race completion marker out of TRRPerformance.jsm. r=johannh!

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1631822 - Implement multiple TRR selection dry-run. r=dragana!,valentin,johannh!

This patch uses TRRPerformance.jsm to get the fastest TRR and store it in a pref
before running DoH heuristics. The chosen TRR URI is sent in a telemetry event.

Depends on D72789

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1631822 - Use geometric mean for fastest TRR selection. r=tdsmith!

Depends on D72790

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1631822 - Return a random TRR from getFastestTRR if requested. r=dragana,valentin

Depends on D73358

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1631822 - Exclude TRRs with more than 30% erroneous results from selection. r=dragana!

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Data Collection Review

Data Review for the extra telemetry event.

Comment 7

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9145053 [details]
Data Collection Review

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, documentation will either be linked from https://docs.telemetry.mozilla.org/datasets/dynamic_telemetry.html, or the event definition will be migrated into Events.yaml before landing, and the probe dictionary will provide documentation.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

n/a

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

The collection reports URLs but they are chosen from a list in browser/components/doh/TRRPerformance.jsm and reflect technical measurements and not user activity, so these are Category 1, technical data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers**?

No.

7) Is the data collection covered by the existing Firefox privacy notice? 

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

Nihanth is response for renewing the collection as required.

9) Does the data collection use a third-party collection tool?

No.

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Tim Smith 👨‍🔬 [:tdsmith] from comment #7)

Comment on attachment 9145053 [details]
Data Collection Review
Yes, documentation will either be linked from
https://docs.telemetry.mozilla.org/datasets/dynamic_telemetry.html, or the
event definition will be migrated into Events.yaml before landing, and the
probe dictionary will provide documentation.

This migration into Events.yaml has been made in the relevant patch (see https://phabricator.services.mozilla.com/D72790?vs=271004&id=271042#toc)

Comment 9

[(inactive) Nihanth Subramanya [:nhnt11]]

https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=bKupVkG5Q3GFBC-WTWl8Og-0&revision=c5a85b7e17a157c92ee704c9f2854118036e0c78

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/550e8058d0ad
Move TRR race completion marker out of TRRPerformance.jsm. r=johannh
https://hg.mozilla.org/integration/autoland/rev/313386beca32
Implement multiple TRR selection dry-run. r=valentin,johannh
https://hg.mozilla.org/integration/autoland/rev/ff87b836486d
Use geometric mean for fastest TRR selection. r=tdsmith,dragana
https://hg.mozilla.org/integration/autoland/rev/b9652dec05a5
Return a random TRR from getFastestTRR if requested. r=johannh
https://hg.mozilla.org/integration/autoland/rev/e689eca5f1a5
Exclude TRRs with more than 30% erroneous results from selection. r=dragana

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/550e8058d0ad
https://hg.mozilla.org/mozilla-central/rev/313386beca32
https://hg.mozilla.org/mozilla-central/rev/ff87b836486d
https://hg.mozilla.org/mozilla-central/rev/b9652dec05a5
https://hg.mozilla.org/mozilla-central/rev/e689eca5f1a5