Closed Bug 1631865 Opened 4 months ago Closed 3 months ago

Make getGridFragments and getAsFlexContainer flush layout

Categories

(Core :: DOM: CSS Object Model, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: bradwerth, Assigned: bradwerth)

Details

Attachments

(1 file)

(This is from discussion from https://phabricator.services.mozilla.com/D71674)

nsGridContainerFrame::GetGridFrameWithComputedInfo checks for a grid frame without doing an initial layout flush. This was an oversight because the function later triggers a flush for the grid frame if it doesn't already have the computed info structure.

This will correctly handle the case of "display:grid" being added or removed
from the Element frame right before the call to getGridFragments on the Element.

Attachment #9142127 - Attachment description: Bug 1631865: Add a layout flush at the beginning of GetGridFrameWithComputedInfo. → Bug 1631865: Add a layout flush to getGridFragments and getAsFlexContainer.
Summary: Make GetGridFrameWithComputedInfo flush before looking for grid frame → Make getGridFragments and getAsFlexContainer flush layout
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bebd73d523a3
Add a layout flush to getGridFragments and getAsFlexContainer. r=emilio
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.