1632021 - Avoid QI between transaction classes

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Each transaction class should have GetAs*Transaction() methods for easier and faster access to concrete classes.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1632021 - part 1: Add `GetAs*Transaction()` methods to every subclasses of `EditTransactionBase` r=m_kato!

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1632021 - part 2: Add `nsITransaction::GetAsEditTransactionBase()` r=m_kato!

In a lot of places in libeditor, we do nothing if given transaction is not
our edit transaction classes' instance. Therefore, it's better to have
casting virtual method in nsITransaction for performance because QI cost
may not be cheap.

Depends on D71907

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1632021 - part 3: Get rid of `nsIAbsorbingTransaction` r=m_kato!

It's inherited only by PlaceholderTransaction and used only for QI.
Therefore, we can get rid of it.

Additionally, this makes storing PlaceholderTransaction and
CompositionTransaction in PlaceholderTransaction faster and safer with
WeakPtr.

Finally, this makes PlaceholderTransaction always have non-null name
because it caused a lot of useless warnings in
EditAggregationTransaction::GetName() and
PlaceholderTransaction::GetTxnName().

Depends on D71908

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1632021 - part 4: Get rid of IID of `InsertTextTransaction` and `CompositionTransaction` r=m_kato!

EditTransactionBase::GetAs*Transaction() should be used instead.

Depends on D71910

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e2e2b767d83
part 1: Add `GetAs*Transaction()` methods to every subclasses of `EditTransactionBase` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a4a7fce9f73e
part 2: Add `nsITransaction::GetAsEditTransactionBase()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/946dc2965175
part 3: Get rid of `nsIAbsorbingTransaction` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/55abc248f524
part 4: Get rid of IID of `InsertTextTransaction` and `CompositionTransaction` r=m_kato

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9e2e2b767d83
https://hg.mozilla.org/mozilla-central/rev/a4a7fce9f73e
https://hg.mozilla.org/mozilla-central/rev/946dc2965175
https://hg.mozilla.org/mozilla-central/rev/55abc248f524