1632025 - SWGL checks for incorrect shader keys

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Lee Salzman [:lsalzman]]

Bug 1604615 caused a regression due to changing the format of shader keys in the shader source to "name feature_feature" whereas before it was "name_feature_feature". Ideally, both are somewhat bad if a feature name has an underscore, so let's take this opportunity to clean it up and make the shader key use "name feature,feature", and only finally resolve it to "name_feature_feature" when we need to generate a filename.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1632025 - fix SWGL shader key parsing. r?jimb

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b54ceab6370
fix SWGL shader key parsing. r=jimb

Comment 3

[Jamie Nicol [:jnicol]]

Ugh, sorry Lee! I'd even noticed you had used the different key format than my WIP patches, but the change must have got lost in one of my many rebases and I forgot about it.

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9b54ceab6370