1632030 - Network's raw headers text selection doesn't persist

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[:Harald Kirschner :digitarald]

STR: Select text in the raw header text.
AR: Text selection doesn't persist.

Right now its an textarea. The click event in the TreeView seems to reset the selection.

Best fix might be switching to a CodeMirror instance with http highlighting, in which case we can dupe this against bug 1618070.

Comment 1

[:Harald Kirschner :digitarald]

Bomsy, would this be a good first bug with some mentoring?

Comment 2

[Hubert Boma Manilla (:bomsy)]

Yeah it is.

For details

1. Here is the location in the Headers Panel that needs to change
   https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/devtools/client/netmonitor/src/components/request-details/HeadersPanel.js#335-340

2. It can be replaced with the SourcePreview component which is located here
   https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/devtools/client/netmonitor/src/components/previews/SourcePreview.js

3. Set the mode to http

Comment 3

[Harshil]

Hey :bomsy I would like to take this bug.

As mentioned above the TextArea has to be replaced with SourcePreview, right?

Below is what it should be replaced with,

SourceView({
    text: value,
    mode: 'http'
})

Please let me know if there's something I am missing out here.

Thanks.

Comment 4

[Hubert Boma Manilla (:bomsy)]

Nice. I've assigned to you.(In reply to Harshil from comment #3)

SourceView({
    text: value,
    mode: 'http'
})

should be SourcePreview. apart from that. That looks correct

Comment 5

[Hubert Boma Manilla (:bomsy)]

Here is a screencast of what the issue is
http://g.recordit.co/BI8SFrN35E.gif

Comment 6

[Harshil]

Hey :bomsy,

I recently submitted a patch for one of the bugs, and I am waiting for it to get reviewed. Should I wait for it to get reviewed and then start working on this? Those changes are not related to this, and are completely different, but I wanted to know how the developer flow is. I would appreciate if you could help me understand it better.

Thanks.

Comment 7

[Hubert Boma Manilla (:bomsy)]

Hey Harshil
No you don't need to wait for it to get reviewed.
You can start another patch , probably do hg up central and the hg commit on that when you are done.

Comment 8

[Harshil]

Hey Hubert,
Thank you for the information. When I try to run hg up central I get an error abort: unknown revision 'central'!. I checked the extensions for hg and firefoxtree is configured. Not sure what is wrong here.

Comment 9

[Harshil]

Attachment: Bug 1632030 - Replaced textarea with SourcePreview in the Headers Panel to make text selection persistent. r=bomsy

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 12

[Andrei Petcu]

I wanted to fix this https://bugzilla.mozilla.org/show_bug.cgi?id=1696128 But then ended up looking at this https://bugzilla.mozilla.org/show_bug.cgi?id=1632030 which is a dupe of the current bug.

I see the current bug had somebody working on it, has a patch but never got merged. Can I pick it up? Will the owner continue? Why was the work paused?

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, please, help welcome on this one.

Thank you,
Honza

Comment 14

[Hubert Boma Manilla (:bomsy)]

Hi Petcuandrei,
There has been no response from Harshil, i think you can pick this up if you like.

Thanks

Comment 15

[Andrei Petcu]

I'll pick this up then. Thank you.

Comment 16

[Hubert Boma Manilla (:bomsy)]

OK assigned to you.

Comment 18

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 20

[Fabien Casters [:vaga]]

Hi,
I would like to work on this bug.

Comment 21

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assigned to you, thank you for helping.

Honza

Comment 22

[Fabien Casters [:vaga]]

Attachment: Bug 1632030 - Replace textarea to `SourcePreview` component to show raw headers r?bomsy

Comment 23

[Fabien Casters [:vaga]]

Attachment: Bug 1632030 - Network's raw headers text selection doesn't persist r?bomsy

Comment 24

[Fabien Casters [:vaga]]

The second patch fix the bug. (https://phabricator.services.mozilla.com/D119782)
As discussed with @nchevobbe, I can create a new bug to add SourcePreview.

Comment 25

[Fabien Casters [:vaga]]

Attachment: Bug 1632030 - Add Code Mirror HTTP mode in SourceEditor r?bomsy

Comment 26

[Phabricator Automation]

Comment on attachment 9231201 [details]
Bug 1632030 - Add Code Mirror HTTP mode in SourceEditor r?bomsy

Revision D119904 was moved to bug 1721126. Setting attachment 9231201 [details] to obsolete.

Comment 27

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 28

[Clinton]

Hi, I'd love to work on this, could it be assigned to me?

Comment 29

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@bomsy: are you working on this one? (or should we re-assign?)

Comment 30

[Hubert Boma Manilla (:bomsy)]

I've pinged Fabien in the bug. It's close i think it just needs a rebase to land. If he is not able to complete, i'll complete and land it.

Comment 31

[Fabien Casters [:vaga]]

Hi,

The main bug is fixed by D119782 in Phabricator. (https://phabricator.services.mozilla.com/D119782)

The two others patchs add the colorscheme in raw HTTP header.
But I catch an another bug in my patch D119761: when we toggle the raw headers, the panel content shifts because CodeMirror take a few milliseconds to build the HTML. There is a video on my comment : https://phabricator.services.mozilla.com/D119761#3927260

Comment 32

[Fabien Casters [:vaga]]

It seems good. :)

Comment 33

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 34

[Abhinav]

Hi Hubert

I would like to work on this issue. Could you please assign it to me?

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4420b5bc7a00
Network's raw headers text selection doesn't persist r=bomsy

Comment 37

[Fabien Casters [:vaga]]

I also worked to replace textarea by SourcePreview. It was never landed.
https://phabricator.services.mozilla.com/D119761

Keep me informed.

Comment 38

[Phabricator Automation]

Comment on attachment 9230957 [details]
Bug 1632030 - Replace textarea to SourcePreview component to show raw headers r?bomsy

Revision D119761 was moved to bug 1795011. Setting attachment 9230957 [details] to obsolete.

Comment 39

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4420b5bc7a00