distribution.id preference is sometimes accessed from the default branch, sometimes as a normal preference
Categories
(Firefox :: Distributions, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox98 | --- | fixed |
People
(Reporter: standard8, Assigned: mkaply)
Details
Attachments
(1 file, 1 obsolete file)
On working on another bug, we just noticed that the distribution.id
preference is sometimes referenced from the default branch, sometimes from the normal "user" preference branch.
I'm guessing that it may have been originally intended that the distribution.id
preference was set on the default branch so users couldn't mess with it, and it would be more difficult for third-party apps to intervene and set.
Whichever way we decide to go, it seems that we should make the code consistent, and/or see if there's a sensible place that could bring all the preference getters into one function handler.
Assignee | ||
Comment 1•4 years ago
|
||
Definitely should always be the default preference.
Comment 2•4 years ago
|
||
Updating Severity from minor
to P4
per May 4th changes to Severity field and triage process.
Assignee | ||
Comment 3•4 years ago
|
||
Comment 4•4 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mkaply, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 5•2 years ago
|
||
Updated•2 years ago
|
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/9ba78c4ebbf2 Always get distribution values from default prefs. r=preferences-reviewers,jaws
Comment 7•2 years ago
|
||
bugherder |
Description
•