1632058 - distribution.id preference is sometimes accessed from the default branch, sometimes as a normal preference

Status: RESOLVED FIXED

(Firefox :: Distributions, defect, P3)

Description

[Mark Banner (:standard8)]

On working on another bug, we just noticed that the distribution.id preference is sometimes referenced from the default branch, sometimes from the normal "user" preference branch.

I'm guessing that it may have been originally intended that the distribution.id preference was set on the default branch so users couldn't mess with it, and it would be more difficult for third-party apps to intervene and set.

Whichever way we decide to go, it seems that we should make the code consistent, and/or see if there's a sensible place that could bring all the preference getters into one function handler.

Comment 1

[Mike Kaply [:mkaply]]

Definitely should always be the default preference.

Comment 2

[Firefox Bug Husbandry Bot]

Updating Severity from minor to P4 per May 4th changes to Severity field and triage process.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1632058 - Always get distribution values from default prefs. r?Standard8!

Comment 4

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mkaply, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Bug 1632058 - Always get distribution values from default prefs. r?Standard8!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ba78c4ebbf2
Always get distribution values from default prefs. r=preferences-reviewers,jaws

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9ba78c4ebbf2

Comment 8

[Mike Kaply [:mkaply]]

This finally landed.