163207 - building standalone transformiix broken using pull_and_build_all

Status: RESOLVED WORKSFORME

(SeaMonkey :: Build Config, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Building standalone transformiix on windows is broken if you build client.mk
with target pull_and_build_all

Steps to reproduce:
1. follow the unix steps on http://www.mozilla.org/projects/xslt/standalone.html
2. build using |make -f client.mk pull_and_build_all| (or no target at all)
3. build using |make -f client.mk build_all|

Step 2 fails, step 3 succeeds

The error in step 2 is:
make[5]: Entering directory `/cygdrive/c/builds/standalone/mozilla/obj-opt/exten
sions/transformiix/source/main'
ArrayList.cpp
touch: creating `.deps/../base/ArrayList.pp': No such file or directory
make[5]: *** [.deps/../base/ArrayList.pp] Error 1
make[5]: Leaving directory `/cygdrive/c/builds/standalone/mozilla/obj-opt/extens
ions/transformiix/source/main'
make[4]: *** [depend] Error 2
make[4]: Leaving directory `/cygdrive/c/builds/standalone/mozilla/obj-opt/extens
ions/transformiix/source'
make[3]: *** [depend] Error 2
make[3]: Leaving directory `/cygdrive/c/builds/standalone/mozilla/obj-opt/extens
ions/transformiix'
make[2]: *** [depend] Error 2
make[2]: Leaving directory `/cygdrive/c/builds/standalone/mozilla/obj-opt'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/c/builds/standalone/mozilla/obj-opt'
make: *** [alldep] Error 2

It seems that when doing a full build (which it always does for some reason
after a pull) results in failure, but when doing a dependent build it works fine.

Comment 1

[Axel Hecht]

Ok, the depend target is broken. No, the way we build tx doesn't like the depend
target. build is fine, but alldep is not. The first checkout goes thru build,
all consecutive ones go thru alldep, that's why you can build the first time 
allright.

I'm adding a deps to bug 103659.

I am rather suprised to this this show up only now, don't have the time right now
to try to reproduce this for the regular Mozilla build.

cls, could you revisit bug 103659, please? Now that nmake builds are dead, and
VPATH doesn't work on win, is it really static libs for each dir?

Comment 2

[Axel Hecht]

Chris suggested to add a $(notdir ) around the deps to create the dependencies
in the main dir. That would have enabled us to build all sources in one dir.
But that has the same problem as the build rule, that is, it looses the link
from the object or dep file to the source file.
I'm clueless whether we could insert the .deps before the filename, but this is
going a bit far for one build.
I guess we should merge 2 or 3 directories in extensions/transformiix and start
building a static lib per dir as everybody else.

Comment 3

[hacker formerly known as [e-mail]]

Attachment: Correct deps via --enable-auto-deps

This patch uses cygpath & sed to convert the automatic variable $< into a
proper dos path.  It still puts the .pp files under build/.deps rather the
../source/*/.deps .

Comment 4

[hacker formerly known as [e-mail]]

Attachment: Build everything from transformiix/build

Comment 5

[hacker formerly known as [e-mail]]

Attachment: Invoke cygpath once per dependency

Comment 6

[Phil Ringnalda (:philor)]

Since there hasn't been a standalone transformiix since 1.8, I bet pull_and_build_all is no more broken than anything else :)