1632073 - [RTL] When the 2-lines layout is activated, the url is displayed beneath the favicon instead of the title

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Itiel]

Attachment: Screenshot

This is because .urlbarView-url is forced to be LTR [1], thus the padding-inline-start for aligning the url with the title [2] does the opposite.

Adding something like this:

.urlbarView-results[wrap] > .urlbarView-row[has-url] > .urlbarView-row-inner:-moz-locale-dir(rtl) > .urlbarView-url {
  padding-right: calc(@urlbarViewItemInlinePadding@ + @identityBoxMarginInlineEnd@ + /* favicon */ 16px);
}

fixes this, but the padding from the existing rule [2] should probably also be separated to a different rule to match LTR only.

Maybe a cleaner solution can be to change [1] to use unicode-bidi: plaintext instead of direction: ltr, but this has the downside of possibly causing spoofing issues.

[1] https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/browser/themes/shared/urlbar-autocomplete.inc.css#153-154
[2] https://searchfox.org/mozilla-central/rev/3446310d6cc5c85cde16a82eccf560e9b71a3d44/browser/themes/shared/urlbar-autocomplete.inc.css#123,125

Comment 1

[Itiel]

Attachment: Bug 1632073 - [RTL] Fix the url padding when 2-line layout is active r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9ecd54c90bb
[RTL] Fix the url padding when 2-line layout is active r=dao

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c9ecd54c90bb