1632080 - Stop sending orphaned crash reports

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P2)

Description

[Calixte Denizet (:calixte)]

Attachment: image.png

For example:
https://crash-stats.mozilla.org/api/SuperSearch/?build_id=20200420153711&release_channel=nightly&signature=%3Dmozilla%3A%3Adom%3A%3AClientSource%3A%3AWindowExecutionReady&product=Firefox&version=77.0a1&date=%3E%3D2020-04-15T00%3A00%3A00.000Z&date=%3C2020-04-22T08%3A34%3A00.000Z

In crash-stop (see screenshot from bug 1631234), it's quite confusing.
The buildids are probably incorrect:
https://bugzilla.mozilla.org/show_bug.cgi?id=1631232#c16

According to :pascalc, we've such crashes from January 2020.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Gabriele Svelto [:gsvelto]]

Sorry I forgot about this. These are orphaned crashes, i.e. crashes for which we have a .dmp file but no .extra file. They used to be a significant problem so I added code to submit them with synthesized metadata. Since we don't know in which version of Firefox they happened the install time field - and many others - is empty. I should have fixed most of the issues that caused them so now there's a very small number and I don't think we care anymore because they should also go a way once I'm done with OOP crash generation. Let's change this bug to disable this behavior and just clean them up.

I'm changing the title accordingly.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Rachel Tublitz [:rachel]]

S1 or S2 bugs need an assignee - could you find someone for this bug?

Comment 5

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1632080 - Stop sending orphaned crash reports with synthesized crash annotations r=mconley

We originally added this functionality in bug 1566855 because we were
seeing a significant amount of orphaned crashes not being submitted.
Notably some of these were early content process startup crashes and
missing them made us unaware of severe issues that would affect our
users. In the meantime we've addressed most of the cases where a crash
would be orphaned. Since the crashes submitted this way have a buildid
that does not match the version of Firefox that actually crashed they
can be confusing during crash triage.

Given the above we can safely remove this functionality. This patch
reverts most of the changes from bug 1566855 but leaves the test
refactorings in place.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a9e8d6ad715
Stop sending orphaned crash reports with synthesized crash annotations r=mconley

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0a9e8d6ad715

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gsvelto, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.