1632096 - Forward WebRender gl(ANGLE) error to gfx critical note

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Sotaro Ikeda [:sotaro]]

On windows, gl context is shared among WebRender renderers, then it seems simpler if gl debug message handling is done at RenderThread.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1632096 - Forward WebRender gl(ANGLE) error message to gfx critical note

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d84032238d5f
Forward WebRender gl(ANGLE) error message to gfx critical note r=gw

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on GLContext.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/ff41a1f6229698c94813230373a2cbc9240e8e8b
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299150651&repo=autoland&lineNumber=33411

Also bustages on RenderThread.cpp : https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299150639&repo=autoland&lineNumber=63193

Comment 5

[Sotaro Ikeda [:sotaro]]

Hmm, when I checked, the error did not happen :(
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1903b05da6ae2afcfebfaa39109f7a00b3c9e04

Comment 6

[Sotaro Ikeda [:sotaro]]

Updated a patch
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72fcfb2d3c0d2d3cd65c426bc27e28321dc0e2d1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/868746c9cd2b
Forward WebRender gl(ANGLE) error message to gfx critical note r=gw

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/868746c9cd2b