1632128 - Simplify unnecessarily complex ResultHelper classes

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P3)

Description

[Simon Giesecke [:sg] [he/him]]

The union in the two ResultHelper classes should be replaced by by mozilla::Variant, which is both safer and simpler to use. Maybe the whole ResultHelper classes can be factored away in the course of this.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1632128 - Use mozilla::Variant for ResultHelper.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1632128 - Use mozilla::Variant for FileHandleResultHelper. r=#dom-workers-and-storage

Depends on D71936

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1632128 - De-virtualize IDBRequest::SetResult(Callback). r=#dom-workers-and-storage

Depends on D74870

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1632128 - De-virtualize IDBFileRequest::SetResult(Callback). r=#dom-workers-and-storage

Depends on D74874

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1632128 - Encapsulate instantiation of ResultHelper. r=#dom-workers-and-storage

Depends on D74875

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1632128 - Dissolve ResultHelper class into a function. r=#dom-workers-and-storage

Depends on D74876

Comment 7

[Simon Giesecke [:sg] [he/him]]

(In reply to Simon Giesecke [:sg] [he/him] from comment #0)

The union in the two ResultHelper classes should be replaced by by mozilla::Variant, which is both safer and simpler to use. Maybe the whole ResultHelper classes can be factored away in the course of this.

Actually, no mozilla::Variant is necessary either, the classes can be made static, with no data members at all.

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1632128 - Dissolve FileHandleResultHelper class into a function. r=#dom-workers-and-storage

Depends on D74890

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e01603c2600
Use mozilla::Variant for ResultHelper. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/e4f2bb3f4635
Use mozilla::Variant for FileHandleResultHelper. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/b1d098d0edcf
De-virtualize IDBRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/4c55bf108c9b
De-virtualize IDBFileRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/1e9b275f2afa
Dissolve ResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/7c0d5a5a3f2a
Dissolve FileHandleResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7e01603c2600
https://hg.mozilla.org/mozilla-central/rev/e4f2bb3f4635
https://hg.mozilla.org/mozilla-central/rev/b1d098d0edcf
https://hg.mozilla.org/mozilla-central/rev/4c55bf108c9b
https://hg.mozilla.org/mozilla-central/rev/1e9b275f2afa
https://hg.mozilla.org/mozilla-central/rev/7c0d5a5a3f2a