Simplify unnecessarily complex ResultHelper classes
Categories
(Core :: Storage: IndexedDB, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
Details
Attachments
(6 files, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
The union
in the two ResultHelper
classes should be replaced by by mozilla::Variant
, which is both safer and simpler to use. Maybe the whole ResultHelper classes can be factored away in the course of this.
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D71936
Assignee | ||
Comment 3•4 years ago
|
||
Depends on D74870
Assignee | ||
Comment 4•4 years ago
|
||
Depends on D74874
Assignee | ||
Comment 5•4 years ago
|
||
Depends on D74875
Assignee | ||
Comment 6•4 years ago
|
||
Depends on D74876
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
(In reply to Simon Giesecke [:sg] [he/him] from comment #0)
The
union
in the twoResultHelper
classes should be replaced by bymozilla::Variant
, which is both safer and simpler to use. Maybe the whole ResultHelper classes can be factored away in the course of this.
Actually, no mozilla::Variant
is necessary either, the classes can be made static, with no data members at all.
Assignee | ||
Comment 8•4 years ago
|
||
Depends on D74890
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 10•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7e01603c2600
https://hg.mozilla.org/mozilla-central/rev/e4f2bb3f4635
https://hg.mozilla.org/mozilla-central/rev/b1d098d0edcf
https://hg.mozilla.org/mozilla-central/rev/4c55bf108c9b
https://hg.mozilla.org/mozilla-central/rev/1e9b275f2afa
https://hg.mozilla.org/mozilla-central/rev/7c0d5a5a3f2a
Description
•