1632131 - Implement the string metric type

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Jan-Erik Rediger [:janerik]]

Implement a string metric for Project FOG

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1632131 - Implement a string metric for the in-tree Glean API. r?chutten!

Currently there's no user, so we do some trickery to actually make sure
it gets compiled.

It also lacks any test, due to it being a bit more complex to set up a
Glean instance for a test run (we need a temporary directory and we need
the additional info and ... lots of boiler plate)

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Jan-Erik Rediger [:janerik] from comment #1)

It also lacks any test, due to it being a bit more complex to set up a
Glean instance for a test run (we need a temporary directory and we need
the additional info and ... lots of boiler plate)

Maybe this is a good reason to put this in "glean-sdk" :-P

Comment 3

[Jan-Erik Rediger [:janerik]]

(In reply to Alessio Placitelli [:Dexter] from comment #2)

(In reply to Jan-Erik Rediger [:janerik] from comment #1)

It also lacks any test, due to it being a bit more complex to set up a
Glean instance for a test run (we need a temporary directory and we need
the additional info and ... lots of boiler plate)

Maybe this is a good reason to put this in "glean-sdk" :-P

well, yeah, for that part (I'm less worried about it now, it's literally just forwarding the call).
But later we will have IPC in that part of the code and that will need tests (but that will then require a full firefox anyway)

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1632131 - Simple smoke test for FOG's string metric type. r?chutten!

A first Rust test, which should run without any interaction with
Firefox.
This will eventually break down when we get IPC in there.

Depends on D72128

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/559882b9b092
Implement a string metric for the in-tree Glean API. r=chutten
https://hg.mozilla.org/integration/autoland/rev/7715960a9f53
Simple smoke test for FOG's string metric type. r=chutten

Comment 6

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=7715960a9f53b7f1099cbfec01be248952bca06a&tochange=a7cafec28c8e15e7bf22b85adaaa92ce8476f5e4&searchStr=sm&selectedJob=299277833

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=299279914&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/a7cafec28c8e15e7bf22b85adaaa92ce8476f5e4

[task 2020-04-24T16:26:29.879Z] + export RUSTFMT=/builds/worker/fetches/rustc/bin/rustfmt
[task 2020-04-24T16:26:29.879Z] + RUSTFMT=/builds/worker/fetches/rustc/bin/rustfmt
[task 2020-04-24T16:26:29.879Z] + export RUST_BACKTRACE=1
[task 2020-04-24T16:26:29.879Z] + RUST_BACKTRACE=1
[task 2020-04-24T16:26:29.879Z] + export AUTOMATION=1
[task 2020-04-24T16:26:29.879Z] + AUTOMATION=1
[task 2020-04-24T16:26:29.879Z] + cargo build --verbose --frozen --features debugmozjs
[task 2020-04-24T16:26:31.162Z] error: the lock file /builds/worker/workspace/build/src/Cargo.lock needs to be updated but --frozen was passed to prevent this
[fetches 2020-04-24T16:26:31.171Z] removing /builds/worker/fetches
[fetches 2020-04-24T16:26:31.660Z] finished
[taskcluster 2020-04-24 16:26:32.193Z] === Task Finished ===
[taskcluster 2020-04-24 16:26:32.288Z] Artifact "public/build" not found at "/builds/worker/artifacts/"
[taskcluster 2020-04-24 16:26:32.435Z] Unsuccessful task run with exit code: 101 completed in 38.993 seconds

Comment 7

[Chris H-C :chutten]

Looks like there's an extra line in Cargo.lock. Lemme remove that and resubmit.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adc3d5d6d340
Implement a string metric for the in-tree Glean API. r=chutten
https://hg.mozilla.org/integration/autoland/rev/d2d6233b7691
Simple smoke test for FOG's string metric type. r=chutten

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/adc3d5d6d340
https://hg.mozilla.org/mozilla-central/rev/d2d6233b7691