1632132 - Dark theme - screen reader - previous/next buttons appear disabled due to color scheme picked

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P1)

Description

[Cristian Fogel [:cfogel]]

Affected versions

• 76.0b7, 77.0a1(2020.04.20)

Affected platforms

• Windows 10, macOS 10.15.3, Ubuntu 18.04;

Steps to reproduce

1. Launch Firefox and access https://longform.org/best
2. Click on the button to trigger the reader mode;
3. Change the theme for it on Black/Dark;
4. Click on the Narrate button click on the play button;
5. Click on Play to start narration;
6. Click on the Next/Previous button;

Expected result

• buttons appear as being available;

Actual result

• due to color setup next/previous buttons appear as being unavailable;

Regression range

• will check and provide one asap;

Additional notes

• attached recording to better illustrate the issue;
• ideally color would be changed to white as well for the 2 buttons, at least once available.

Comment 1

[Cristian Fogel [:cfogel]]

Attachment: Screenshot 0002-04-22 at 15.51.39.png

Recording for it.

Comment 2

[abodenlosz]

Initially tested the issues on Windows 10 x64 with Firefox 75.0. Updating the status flag as well.

• Regression range:
• Last good: 2019-04-22
• First bad: 2019-04-23
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c7eaf384b06cfda8314be34cd179ab46f271ccc&tochange=4b0811d7b8e1591d4e48a26bdb8666a1bc5ccf61
• Possible regressor: https://bugzilla.mozilla.org/show_bug.cgi?id=1187696

Comment 3

[Cristian Fogel [:cfogel]]

Thanks for the updates @Julien & abodenlosz.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

I suspect this is because these rules:

https://searchfox.org/mozilla-central/rev/41c3ea3ee8eab9ce7b82932257cb80b703cbba67/toolkit/themes/shared/narrate.css#113-114,120-121

are overriding this rule:

https://searchfox.org/mozilla-central/rev/41c3ea3ee8eab9ce7b82932257cb80b703cbba67/toolkit/themes/shared/aboutReader.css#258-262

The hardcoded values in narrate.css don't seem to be compatible with the dark theme, so it probably makes sense to fallback to using the values defined in aboutReader.css, which automatically adjust between dark and light theme.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1632132 - Fix about:reader narrate back and forward buttons for dark theme. r?ntim!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88fd740ab35c
Fix about:reader narrate back and forward buttons for dark theme. r=ntim

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/88fd740ab35c

Comment 8

[abodenlosz]

Verified the fix with Nightly 77.0a1 (2020-04-26) on Windows 10 x64. Updating the flag to verified.

Comment 9

[abodenlosz]

Also verified on macOS 10.15 and Ubuntu 18.04 x64 with the latest Nightly build.