1632319 - Sound icon persists on discarded tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[kernp25]

Attachment: otr18pweHw.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Install: https://addons.mozilla.org/firefox/addon/unload-tab/
Open a Youtube video with sound in a new tab.
Wait for the play or sound icon to appear and then right-click on the tab and unload it.

Actual results:

The sound indicator icon to mute the tab (not to unmute) or the play icon is still there.

Expected results:

The sound indicator icon to mute the tab (not to unmute) or the play icon should also be removed (because there is no sound or video anymore).

Comment 1

[kernp25]

Attachment: 9rN6KjnPot.mp4

Comment 2

[kernp25]

Also clicking on the play icon on the unloaded tab doesn't do anything.

Comment 3

[kernp25]

(In reply to kernp25 from comment #2)

Also clicking on the play icon on the unloaded tab doesn't do anything.

Note: If the tab is pinned then it works as expected (the tab loads and plays the video).

Tested in 77.0a1 (2020-04-22).

Comment 4

[kernp25]

Or should it load the tab when clicking on the play icon?

Comment 5

[kernp25]

But i think the play icon doesn't make sense anymore (because there is no audio anymore).

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 7

[Alex Cornestean]

Hello,

I have managed to reproduce the issue based on the provided STR on the latest Nightly (77.0a1/20200423214309), Beta (76.0b8/20200424000239) and Release (75.0/20200403170909) under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS.

The sound indicator icon to mute the tab is still there after unloading the tab. Furthermore, I can also confirm the behavior from Comment 3.

Regarding a possible regression window, I’ve run a regression range from 01.01.2018 until the present date and all tested versions are affected by this issue. Considering this, it seems that the bug might not be a regression but the common behavior.

Comment 8

[Dão Gottwald [:dao]]

The mute icon should stay there as the tab will continue to be muted when restoring it.

Comment 9

[Dão Gottwald [:dao]]

Attachment: Bug 1632319 - Remove soundplaying icon from tab when discarding browser. r=jaws

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41018db33b42
Remove soundplaying icon from tab when discarding browser. r=jaws

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/41018db33b42

Comment 12

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Beta 77.0b7 on Windows 10 and MacOS 10.13.
Sound icon does not persist anymore after unloading a tab (this applies to pinned tabs too).
The mute icon persists after unloading the tab.