Closed
Bug 1632345
Opened 5 years ago
Closed 5 years ago
mach doctor shouldn't complain about noatime/relatime missing on tmpfs
Categories
(Firefox Build System :: General, enhancement, P3)
Firefox Build System
General
Tracking
(firefox78 fixed)
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: glandium, Assigned: adiabtaic28394, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: lang=python)
Attachments
(1 file)
Running mach doctor shows this on my system:
/tmp has no explicit noatime/relatime mount option... BAD
But that doesn't matter because /tmp is a tmpfs on this machine.
|
Reporter | |
Updated•5 years ago
|
Keywords: good-first-bug
|
|
Reporter | |
Updated•5 years ago
|
Mentor: mh+mozilla
|
|
Reporter | |
Updated•5 years ago
|
Whiteboard: lang=python
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•5 years ago
|
||
Hey I'd like to work on this bug.
I was able to build Firefox and found the function which causes this bug (check_mount_lastaccess in python/mozbuild/mozbuild/doctor.py)
I suggest to check whether fstype is equal to tmpfs and if that's the case then print '<mountpoint> is a tmpfs so noatime/reltime is not needed' and status would be GOOD.
What do you think?
|
|
Reporter | |
Comment 2•5 years ago
|
||
That sounds sensible, although it's probably not worth printing a message at all.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → adiabtaic28394
Status: NEW → ASSIGNED
Pushed by jwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be25dcaaad43
mach doctor does not complain about noatime/reltime on tmpfs anymore r=Callek,glandium
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•