Closed Bug 1632345 Opened 6 years ago Closed 5 years ago

mach doctor shouldn't complain about noatime/relatime missing on tmpfs

Categories

(Firefox Build System :: General, enhancement, P3)

Product:
Firefox Build System
Component:
General
Type:
enhancement

Tracking

(firefox78 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: glandium, Assigned: adiabtaic28394, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: lang=python)

Attachments

(1 file)

Bug 1632345 - mach doctor does not complain about noatime/reltime on tmpfs anymore r=Callek
47 bytes, text/x-phabricator-request
Details

Running mach doctor shows this on my system:

/tmp has no explicit noatime/relatime mount option...                           BAD

But that doesn't matter because /tmp is a tmpfs on this machine.

Keywords: good-first-bug
Mentor: mh+mozilla
Whiteboard: lang=python
Priority: -- → P3

Hey I'd like to work on this bug.
I was able to build Firefox and found the function which causes this bug (check_mount_lastaccess in python/mozbuild/mozbuild/doctor.py)

I suggest to check whether fstype is equal to tmpfs and if that's the case then print '<mountpoint> is a tmpfs so noatime/reltime is not needed' and status would be GOOD.

What do you think?

That sounds sensible, although it's probably not worth printing a message at all.

Assignee: nobody → adiabtaic28394
Status: NEW → ASSIGNED
Pushed by jwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be25dcaaad43 mach doctor does not complain about noatime/reltime on tmpfs anymore r=Callek,glandium

https://hg.mozilla.org/mozilla-central/rev/be25dcaaad43

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: