1632351 - Enable CSS conic-gradient by default and let it ride the trains

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Tim Nguyen :ntim]

I'm filing this bug to track issues blocking enabling conic gradients by default for everyone on release.

Right now, there's only the Direct2D implementation left in that list. I'm planning to work on this as soon as I have a Windows dev environment available. But if there's any other bug preventing shipping, please feel free to add it as dependency to this bug.

Comment 1

[j.j.]

Isn't bug 1617039 necessary for printing?
If so, it should block this (think on printing circle charts).

Comment 2

[Tim Nguyen :ntim]

(In reply to j.j. from comment #1)

Isn't bug 1617039 necessary for printing?
If so, it should block this (think on printing circle charts).

Printing is not essential for the initial release, especially when some platforms are covered by their respective backends.

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1632351 - Enable CSS conic-gradient by default and let it ride the trains. r=emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/699c9b84e8cb
Enable CSS conic-gradient by default and let it ride the trains. r=emilio

Comment 5

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=699c9b84e8cb3107bde4304d953e1a93f49b69e5&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318223493&repo=autoland&lineNumber=2919
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318222945&repo=autoland&lineNumber=3913

Backout: https://hg.mozilla.org/integration/autoland/rev/e8cd7fab7592abe89f664805d03091f950f5e1d0

Comment 6

[Tim Nguyen :ntim]

Seems like conic-gradient doesn't want to ride the train :(

• devtools/shared/tests/xpcshell/test_css-properties-db.js

I think this one needs ./mach devtools-css-db to be re-ran with the pref enabled. Though I wonder if there's a more pref-friendly way for the devtools code, that doesn't require re-generating the DB?

• layout/style/test/test_transitions_per_property.html

Heh, I overlooked this when writing the original test: repeating-conic-gradient(red 1deg, yellow 20%, blue 24em, green) is not correct syntax, length values (24em) don't really make sense here.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7576a306cce4
Enable CSS conic-gradient by default and let it ride the trains. r=emilio

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on layout/style/test/test_value_cloning.html

backout: https://hg.mozilla.org/integration/autoland/rev/9d38bc8708bc2e3bb528f5f3ecdae549c015ddb8

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=F0EtfhkWTCyMLBnw3wGwHg.0&revision=7576a306cce45f262892b410c64582691cb2c976&searchStr=mochitest%2Cplain

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318265968&repo=autoland&lineNumber=3435

[task 2020-10-10T14:22:47.698Z] 14:22:47 INFO - TEST-START | layout/style/test/test_value_cloning.html
[task 2020-10-10T14:22:48.377Z] 14:22:48 INFO - GECKO(1514) | [Child 1630, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:511
[task 2020-10-10T14:22:48.377Z] 14:22:48 INFO - GECKO(1514) | [Child 1630, Main Thread] WARNING: Error sending reply: file /builds/worker/workspace/obj-build/ipc/ipdl/PDocumentChannelChild.cpp:277
[task 2020-10-10T14:22:49.799Z] 14:22:49 INFO - GECKO(1514) | [Child 1630, Main Thread] WARNING: We shouldn't be backing up more than once! Someone must have set a break opportunity beyond the available width, even though there were better break opportunities before it: file /builds/worker/checkouts/gecko/layout/generic/nsBlockFrame.cpp:4374
[task 2020-10-10T14:22:50.001Z] 14:22:50 INFO - GECKO(1514) | [Child 1630, Main Thread] WARNING: We shouldn't be backing up more than once! Someone must have set a break opportunity beyond the available width, even though there were better break opportunities before it: file /builds/worker/checkouts/gecko/layout/generic/nsBlockFrame.cpp:4374
[task 2020-10-10T14:22:53.455Z] 14:22:53 INFO - TEST-INFO | started process screentopng
[task 2020-10-10T14:22:53.693Z] 14:22:53 INFO - TEST-INFO | screentopng: exit 0
[task 2020-10-10T14:22:53.693Z] 14:22:53 INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_value_cloning.html | serialization should be nonempty for -webkit-mask-image: conic-gradient(red 50deg, blue 0.3turn, yellow 200grad, orange 60%, 5rad) - didn't expect "", but got it
[task 2020-10-10T14:22:53.693Z] 14:22:53 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:519:14
[task 2020-10-10T14:22:53.694Z] 14:22:53 INFO - iframe_loaded@layout/style/test/test_value_cloning.html:128:12
[task 2020-10-10T14:22:55.101Z] 14:22:55 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-10T14:22:55.102Z] 14:22:55 INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_value_cloning.html | serialization should be nonempty for -webkit-mask: conic-gradient(red 50deg, blue 0.3turn, yellow 200grad, orange 60%, 5rad) repeat - didn't expect "", but got it
[task 2020-10-10T14:22:55.103Z] 14:22:55 INFO - SimpleTest.isnot@SimpleTest/SimpleTest.js:519:14
[task 2020-10-10T14:22:55.104Z] 14:22:55 INFO - iframe_loaded@layout/style/test/test_value_cloning.html:128:12
[task 2020-10-10T14:23:04.692Z] 14:23:04 INFO - Not taking screenshot here: see the one that was previously logged

Comment 9

[Natalia Csoregi [:nataliaCs]]

also failing: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318267037&repo=autoland&lineNumber=3141

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2468b16a890c
Enable CSS conic-gradient by default and let it ride the trains. r=emilio

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2468b16a890c

Comment 12

[Tim Nguyen :ntim]

Release Note Request (optional, but appreciated)
[Why is this notable]: Long-awaited new CSS feature (see bug 1175958)
[Affects Firefox for Android]: Yes
[Suggested wording]: Added support for CSS conic gradients
[Links (documentation, blog post, etc)]:
https://developer.mozilla.org/docs/Web/CSS/conic-gradient
https://developer.mozilla.org/docs/Web/CSS/repeating-conic-gradient
https://css-tricks.com/background-patterns-simplified-by-conic-gradients/ <---- Mentions Firefox's support behind pref from 75
https://lea.verou.me/2015/06/conical-gradients-today/

Comment 13

[Pascal Chevrel:pascalc]

Note added to Nightly notes.

Comment 14

[Michal Čaplygin [:myf]]

Compat data PR: https://github.com/mdn/browser-compat-data/pull/6904
(Hope it doesn't hijack some process here.)

---

(In reply to Pascal Chevrel:pascalc from comment #13)

Note added to Nightly notes.
(https://www.mozilla.org/en-US/firefox/83.0a1/releasenotes/)

Should it be mentioned in the 83 dev notes now?
(https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/83)

Comment 15

[Pascal Chevrel:pascalc]

(In reply to Michal Čaplygin [:myf] from comment #14)

Should it be mentioned in the 83 dev notes now?
(https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/83)

This is what the dev-doc-needed keyword in this bug is for (it is monitored by the MDN team)

Comment 16

[Rachel Andrew]

Added to release notes for 83, and removed from the Experimental Features page.