Remove profiling duration limit
Categories
(Core :: Gecko Profiler, task, P3)
Tracking
()
People
(Reporter: mozbugz, Unassigned)
Details
The duration limit could be useful in some cases, when doing "continuous profiling" (starting the profiler early during a Firefox session, then work as usual until something interesting happens). Because different processes may have different recording data rates, but they are all using the same buffer size, some processes could have a very long duration, making other processes look tiny at the end of the profiling range.
With the upcoming holistic buffer limitation, this won't be an issue anymore, as the oldest chunks of data (over all of Firefox) will be deleted first, making all processes retain a similar amount of time.
The duration limit is already absent from the new popup, so it's probably not used much anymore.
And the new buffer code will just not support this function anymore, so it won't do anything.
But we still have a lot of supporting code in Gecko, including MOZ_PROFILER_STARTUP_DURATION, and duration parameters in lots of APIs.
This should all be removed if possible.
We may still want to retain a minimum of API code (especially at the public web interface) for some time, so that this parameter could still be given but would be ignored. This could be useful in remote profiling when Firefox versions don't match.
|
Reporter | |
Comment 1•5 years ago
|
||
But if we decide to add this feature back in the popup, ProfileBufferEntry::DiscardSamplesBeforeTime() will need to be re-implemented after bug 1630872.
Description
•