1632388 - Devtools properties-db.js.in (template) and properties-db.js (generated file) have the wrong path to their script

Status: RESOLVED FIXED

(DevTools :: Shared Components, task)

Description

[Daniel Holbert [:dholbert]]

properties-db.js.in and properties-db.js have a code-comment saying:

• [...] The actual script
• to generate these files can be found at devtools/shared/css/generate-properties-db.js.

However, no such file exists at that location in the tree.

There's just a missing subdirectory -- the script lives in the generated/ subdirectory within the referenced css directory. We should fix the code comment to match reality.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1632388 part 1: Update devtools properties-db.js.in template to correct a typo in a code-comment's reference to an in-tree directory. r?gregtatum

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1632388 part 2: Regenerate the devtools CSS db (to pick up a typo-fix from its template). r?gregtatum

This patch's changes were automatically generated by the following command:
./mach devtools-css-db

Depends on D72097

Comment 4

[Daniel Holbert [:dholbert]]

Perhaps it's overkill, but for maximal purity/cleanliness, I split this into two parts -- editing the template in "part 1", and regenerating the generated file in "part 2" (so that changes to manually-written files vs. auto-generated files are in separate commits).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a72b3f178ca3
part 1: Update devtools properties-db.js.in template to correct a typo in a code-comment's reference to an in-tree directory. r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/cbc332a9c91d
part 2: Regenerate the devtools CSS db (to pick up a typo-fix from its template). r=gregtatum

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a72b3f178ca3
https://hg.mozilla.org/mozilla-central/rev/cbc332a9c91d