1632405 - Save/Update doorhanger on form submit is not displayed for fields where new credentials were filled in after deleting autofilled ones or field edits

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

+++ This bug was initially created as a clone of Bug #1627658 +++

Affected Versions
Nightly 77.0a1(2020-04-22)

Tested on
Windows 10 x64

Steps to reproduce

1. Have 1 set of credentials saved on facebook.com
2. Load the Log in Form (ensure credentials are autofilled)
3. Delete the autofilled credentials and type in new ones (observe the grey key icon)
4. Click on Log In

Expected
The save doorhanger should be displayed on form submit (replaces the dismissed one)

Actual
Save doorhanger on form submit is not displayed, the grey key for the dismissed doorhanger remains displayed

Regression-Range
This regressed recently on Nightly due to Bug 1532377.
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6c5eddde0f5b187cb6891549d0d279394cd65423&tochange=cf66def9cbd002f21bab8e55083a165f82ea0217

Comment 1

[Timea Cernea [:tbabos][inactive]]

Hey Severin, could you take a look at this when you have the time? Thanks!

Comment 2

[Matthew N. [:MattN]]

Severin, can you take this after bug 1630191? This doesn't affect 76 so is lower priority than that one. Maybe your fix for that can take this bug into account and address both? I don't have enough context to know if that makes sense but they seem related.

Comment 3

[:severin Rudie]

Will do!

Comment 4

[:severin Rudie]

Attachment: Bug 1632405 - Fix login autofill-> delete-> fill-> save flow;r=MattN

RCA:
Bug 1532377 moved docState (inside _maybeSendFormInteractionMessage) closer to its use site. This accidentally changed the order of a short, which resulted in site-prompted changes being saved in _compareAndUpdatePreviouslySentValues, later causing _compareAndUpdatePreviouslySentValues to return false on true form submit events.

Comment 5

[Timea Cernea [:tbabos][inactive]]

This also affects the scenarios when we:
Edit the autofilled username or password and hit Log in.

Expected:
Save credentials or update password doorhanger should be displayed on form submit.
Actual:
The above-mentioned doorhangers are not displayed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87f89c55ae64
Fix login autofill-> delete-> fill-> save flow;r=MattN

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/87f89c55ae64

Comment 8

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Nightly 77.0a1 (2020-05-03) on Windows 10 x64, MacOS 10.13 and Ubuntu 16.04.
The Save/Update doorhnager appears when on form submit when:

1. New credentials are typed in after clearing autofilled ones
2. The username or the password of autofilled credentials are edited