Closed Bug 1632413 Opened 5 years ago Closed 5 years ago

Remove webConsoleCommands trait

Categories

(DevTools :: Console, task)

task

Tracking

(firefox77 fixed)

RESOLVED FIXED
Firefox 77
Tracking Status
firefox77 --- fixed

People

(Reporter: nchevobbe, Assigned: antoine.granjon, Mentored)

Details

Attachments

(1 file)

A trait is a property we define on an server object, to indicate to the client if a given feature is available (because clients can connect to older servers).

This is why in Firefox 40, we added this devtools/server/actors/root.js#141-143.

As we only maintain backward compatibility for (current version - 2), and since we're at Firefox 77, I think we can safely remove the trait.

The trait is only used in devtools/client/definitions.js#421, and we can replace it with return true

I would like to work on this bug

Hello Antoine, the bug is now yours :) Thanks for offering help!

Assignee: nobody → antoine.granjon
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48b4cde9c59c Remove webConsoleCommands trait. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: