1632488 - Content autocomplete drop-down contents are grey/invisible

Status: RESOLVED WORKSFORME

(Toolkit :: Form Manager, defect)

Description

[:Gijs (he/him)]

Attachment: Screenshot

[Tracking Requested - why for this release]:
User-visible regression

STR:

1. have a profile with at least 1 remembered email
2. Open:

data:text/html,<input id="email" type="email" name="email" autocomplete="email" spellcheck="false" placeholder="Email" title="Email" class="">

3. click in the inputbox.

ER:
can pick an email to autocomplete

AR:
A grey box pops up (see attachment from simpletax.ca which uses this markup in practice) without any text.

This works as expected for me in beta, so I expect it's a recent regression.

Comment 1

[:Gijs (he/him)]

Hrmpf, except I can't reproduce in a clean profile, but can reproduce reliably in my regular nightly testing profile. I don't know why.

Comment 2

[:Gijs (he/him)]

Matt, any ideas how I can track down what's going wrong here? I'm not super familiar with form autofill so I don't really understand why there's suddenly a different background colour and no text. If I use the inspector, I see a richlistbox with 2 items:

<richlistbox xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" class="autocomplete-richlistbox" flex="1" allowevents="true" height="40">
  <richlistitem is="autocomplete-richlistitem" class="autocomplete-richlistitem" dir="ltr" ac-image="" ac-value="[e-mail]" ac-label="" ac-comment="[e-mail]" ac-text="" originaltype="" type="" url="[e-mail]" image="" title="[e-mail]" text=""><image class="ac-type-icon" type=""/><image class="ac-site-icon" type="" src=""/><hbox class="ac-title" align="center"><description class="ac-text-overflow-container"><description class="ac-title-text">[e-mail]</description></description></hbox><hbox class="ac-separator" align="center" type=""><description class="ac-separator-text" value="—"/></hbox><hbox class="ac-url" align="center" aria-hidden="true"><description class="ac-text-overflow-container"><description class="ac-url-text">[e-mail]</description></description></hbox></richlistitem>
  <richlistitem is="autocomplete-richlistitem" class="autocomplete-richlistitem" dir="ltr" ac-image="" ac-value="[e-mail]" ac-label="" ac-comment="[e-mail]" ac-text="" originaltype="" type="" url="[e-mail]" image="" title="[e-mail]" text=""><image class="ac-type-icon" type=""/><image class="ac-site-icon" type="" src=""/><hbox class="ac-title" align="center"><description class="ac-text-overflow-container"><description class="ac-title-text" style="max-width: 139px;">[e-mail]</description></description></hbox><hbox class="ac-separator" align="center" type=""><description class="ac-separator-text" value="—"/></hbox><hbox class="ac-url" align="center" aria-hidden="true"><description class="ac-text-overflow-container"><description class="ac-url-text" style="max-width: 47.26px;">[e-mail]</description></description></hbox></richlistitem>
</richlistbox>

which looks plausible enough? I don't see relevant errors in the browser console...

Comment 4

[Matthew N. [:MattN]]

This is a dupe of bug 1632255 but you have some more details so I duped it here.

Which macOS version are you using? TCinotto was running macOS 10.14.5 and could also reproduce but I can't repro on 10.15.4… though maybe that doesn't mean much if it's not reproducible for you in a new profile. Do you happen to know if you did a macOS upgrade recently or do you think this correlates with a Nightly version?

(In reply to :Gijs (he/him) from comment #2)

Matt, any ideas how I can track down what's going wrong here? I'm not super familiar with form autofill so I don't really understand why there's suddenly a different background colour and no text. If I use the inspector, I see a richlistbox with 2 items:

So you don't see grey/transparent as a background colour on any of the elements in the popup? I don't know of any recent change that would be relevant. (Bug 1630681 is possibly related but that change shouldn't cause this in theory).

If you can clone your profile and run mozregression we can try figure out what caused this.

Comment 5

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #4)

This is a dupe of bug 1632255 but you have some more details so I duped it here.

Which macOS version are you using? TCinotto was running macOS 10.14.5 and could also reproduce but I can't repro on 10.15.4… though maybe that doesn't mean much if it's not reproducible for you in a new profile. Do you happen to know if you did a macOS upgrade recently or do you think this correlates with a Nightly version?

I haven't recently done a macOS upgrade. I'm still on whatever the latest version of 10.14 is.

(In reply to :Gijs (he/him) from comment #2)

Matt, any ideas how I can track down what's going wrong here? I'm not super familiar with form autofill so I don't really understand why there's suddenly a different background colour and no text. If I use the inspector, I see a richlistbox with 2 items:

So you don't see grey/transparent as a background colour on any of the elements in the popup?

I didn't check this. :-(

I don't know of any recent change that would be relevant. (Bug 1630681 is possibly related but that change shouldn't cause this in theory).

If you can clone your profile and run mozregression we can try figure out what caused this.

I tried to do this in order to trace bug 1632544 - and couldn't repro it with mozregression. Then I tried using ./mach run with that profile to reproduce that bug, and that (a) made it go away and (b) made this bug go away. :-(

So I suspect this is related to bug 1632544, though not everyone who can repro that can repro this bug...

Comment 6

[Matthew N. [:MattN]]

So far everyone who is seeing this issue is on 10.14: Gijs, groovecoder, Tony, Standard8

mconley who was seeing the OOM issues doesn't have this issue on 10.15.

Comment 7

[Matthew N. [:MattN]]

Now that you fixed bug 1632544, do you think this is a dupe of it?

Comment 8

[:Gijs (he/him)]

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #7)

Now that you fixed bug 1632544, do you think this is a dupe of it?

I don't know for sure, but we can probably just close this as WFM and we can reopen if it resurfaces on builds that have the fix for 1632544?

Comment 9

[Dietrich Ayala (:dietrich)]

I'm on Mac OS X 10.14.6, nightly build date of 2020-04-26, and am still seeing this bug.

Bug 1632544 was fixed a couple of days ago, so I should have the fix right?

Comment 10

[:Gijs (he/him)]

(In reply to Dietrich Ayala (:dietrich) from comment #9)

I'm on Mac OS X 10.14.6, nightly build date of 2020-04-26, and am still seeing this bug.

Bug 1632544 was fixed a couple of days ago, so I should have the fix right?

Yes. Are you seeing errors in the browser console mentioning "out of memory" errors?

Comment 11

[Mark Banner (:standard8)]

I think I'm still seeing this as well. The form in comment 0 is working, however if I go into private mode and try to log into Firefox accounts, then I'm getting the grey, or even a blue-grey faded box.

Comment 12

[Mark Banner (:standard8)]

Oh, and I forgot to say, no out of memory errors in the console (nor other relevant info).

Comment 13

[Dietrich Ayala (:dietrich)]

Hrm, now I'm not able to reproduce. Same build. Argh, user error before maybe. Tried private mode, still works ok for me now.

Comment 14

[Mark Banner (:standard8)]

With today's start of Firefox / upgrade to the latest nightly private mode has started working fine again.

Back to WFM?

Comment 15

[Matthew N. [:MattN]]

Groovecoder can no longer repro either.