Trigger incremental GC slices for malloc allocations as we currently do for GC allocations
Categories
(Core :: JavaScript: GC, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
We currently use ZoneAllocator::gcDelayBytes to trigger slices on GC allocations (every 1MB by default), so that we still get incremental slices if we're stuck in a loop allocating. The aim of this bug is to extend this to malloc allocations associated with GC things too.
|
Assignee | |
Comment 1•4 years ago
|
||
This extends HeapThreshold to hold a threshold for starting a new slice as well as starting a collection and uses the appropriate threshold. We can then remove gcDelayBytes and get this behaviour for malloc allocations too.
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/82dc44ab84c0 Trigger incremental GC slices for malloc allocations as we currently do for GC allocations r=sfink
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
== Change summary for alert #25721 (as of Sun, 26 Apr 2020 04:49:32 GMT) ==
Improvements:
8% raptor-ares6-firefox macosx1014-64-shippable opt 59.04 -> 54.28
4% raptor-ares6-firefox linux64-shippable opt 46.42 -> 44.73
3% raptor-ares6-firefox windows10-64-shippable opt 47.72 -> 46.17
3% raptor-ares6-firefox windows7-32-shippable opt 47.94 -> 46.39
2% raptor-ares6-firefox windows7-32-shippable opt 47.59 -> 46.63
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25721
Description
•