1632539 - Edit bookmark panel color changed in dark theme

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect, P3)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screenshot showing the issue

Affected versions

• Firefox Nightly (2020-04-23)

Affected platforms

• MacOS 10.15.5

Unaffected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit

Steps to reproduce

1. Start Firefox
2. Make sure to have the Dark theme enabled
3. Visit any website
4. Bookmark the page by clicking the star icon
5. Click Show all the bookmark folders
6. Hover + New Folder button

Expected result

• Hovering + New Folder button has the same color as the panel

Actual result

• Hovering + New Folder button has a different color as the panel

Regression range

• First bad: 6392325ec39e5cb10edd4aaaa4afb7a9f061b0b2
• Last good: ad3f58c996e59bc5ca0a0e6aac61c8f6a7e51096
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ad3f58c996e59bc5ca0a0e6aac61c8f6a7e51096&tochange=6392325ec39e5cb10edd4aaaa4afb7a9f061b0b2
• Potential regressor: Bug 455077 - Enable color management for all CSS/images, not just tagged images

Additional notes

• Not sure if this change was intended or not, it looks kind of wrong to me. Andrew can you share your opinion here?
• The panel from the left is the one that I consider bad (Latest Nightly).

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

The change is likely intended from the graphics perspective (barring some bug in the profile handling). We did not color manage CSS colors before, so the way they would show up on different monitors was completely different. Now it should be fairly consistent. I'm not sure what front end expected in this case however.

Comment 2

[Dão Gottwald [:dao]]

The button hover background matched the panel background only approximately, and only by accident, I think. This change seems fine.