Closed Bug 1632594 Opened 4 years ago Closed 4 years ago

GeckoSession#onExternalResponse is getting called with negative values on response.contentLength

Categories

(GeckoView :: General, defect, P1)

Unspecified
All

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: amejia, Assigned: m_kato)

References

Details

(Whiteboard: [geckoview:m78])

Attachments

(1 file)

STP

  1. Try to download https://osdn.net/projects/manjaro/storage/xfce/19.0.2/manjaro-xfce-19.0.2-200311-linux54.iso/
  2. onExternalResponse gets called with theresponse.contentLength equal to -1522876416
Severity: -- → normal
Rank: 5
Priority: -- → P1
Whiteboard: [geckoview:m78]
Assignee: nobody → m_kato

When content length is over 2GB, WebResponseInfo.contentLength is negative
value. Use Long.valueOf instead of Integer.valueOf to pass this value.

Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/7a235bf95a00
Use Long.valueOf instead of Integer.valueOf on GeckoSession#onExternalResponse. r=geckoview-reviewers,agi
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78

We are still seeing this issue on 79.0.20200615092624 , to simulate just try to download this file

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
See Also: → 1646246
Flags: needinfo?(m_kato)

(In reply to Arturo Mejia from comment #5)

We are still seeing this issue on 79.0.20200615092624 , to simulate just try to download this file

Your test is incorrect. -1 is valid for content length for this site (This web server returns unknown length).

Could you test this when web server returns over 4GB value for content-length really?

Flags: needinfo?(m_kato) → needinfo?(amejiamarmol)

(In reply to Makoto Kato [:m_kato] from comment #6)

(In reply to Arturo Mejia from comment #5)

We are still seeing this issue on 79.0.20200615092624 , to simulate just try to download this file

Your test is incorrect. -1 is valid for content length for this site (This web server returns unknown length).

Could you test this when web server returns over 4GB value for content-length really?

Sure no problem!

Flags: needinfo?(amejiamarmol)

The values is as expected with content length larger than 4GB value. I think we can close this bug

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: