1632594 - GeckoSession#onExternalResponse is getting called with negative values on response.contentLength

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Arturo Mejia [:amejia]]

STP

1. Try to download https://osdn.net/projects/manjaro/storage/xfce/19.0.2/manjaro-xfce-19.0.2-200311-linux54.iso/
2. onExternalResponse gets called with theresponse.contentLength equal to -1522876416

Comment 1

[Emily Toop (:fluffyemily)]

https://searchfox.org/mozilla-central/source/mobile/android/components/geckoview/GeckoViewExternalAppService.cpp#107 Duh!

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1632594 - Use Long.valueOf instead of Integer.valueOf on GeckoSession#onExternalResponse.

When content length is over 2GB, WebResponseInfo.contentLength is negative
value. Use Long.valueOf instead of Integer.valueOf to pass this value.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a235bf95a00
Use Long.valueOf instead of Integer.valueOf on GeckoSession#onExternalResponse. r=geckoview-reviewers,agi

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7a235bf95a00

Comment 5

[Arturo Mejia [:amejia]]

We are still seeing this issue on 79.0.20200615092624 , to simulate just try to download this file

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Arturo Mejia from comment #5)

We are still seeing this issue on 79.0.20200615092624 , to simulate just try to download this file

Your test is incorrect. -1 is valid for content length for this site (This web server returns unknown length).

Could you test this when web server returns over 4GB value for content-length really?

Comment 7

[Arturo Mejia [:amejia]]

(In reply to Makoto Kato [:m_kato] from comment #6)

(In reply to Arturo Mejia from comment #5)

We are still seeing this issue on 79.0.20200615092624 , to simulate just try to download this file

Your test is incorrect. -1 is valid for content length for this site (This web server returns unknown length).

Could you test this when web server returns over 4GB value for content-length really?

Sure no problem!

Comment 8

[Arturo Mejia [:amejia]]

The values is as expected with content length larger than 4GB value. I think we can close this bug