Closed Bug 1632595 Opened 3 months ago Closed 3 months ago

Rust 1.43 errors in bits_interface

Categories

(Toolkit :: Application Update, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

New warning-as-error in Rust 1.43:

0:07.01 warning: unused doc comment
0:07.01 --> toolkit\components\bitsdownload\src\bits_interface\monitor.rs:143:5
0:07.01 |
0:07.01 143 | /// This method is essentially a error-handling wrapper around try_run.
0:07.01 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macros
0:07.01 |
0:07.01 = note: #[warn(unused_doc_comments)] on by default
0:07.01 = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion

Same at request.rs:687.

Apparently doc comments aren't meaningful on macros, and Rust 1.43 introduced a new lint for this.

Assignee: nobody → dmajor
Status: NEW → ASSIGNED
Blocks: rustup
Blocks: 1632723
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b74b50fc17e
Fix Rust 1.43 errors in bits_interface doc comments r=bytesized
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.