Closed Bug 1632641 Opened 4 months ago Closed 4 months ago

Intermittent very frequent browser/components/extensions/test/browser/browser_ext_tabs_zoom.js | Got expected zoom event tab ID - Expected: "x", Actual: "y"-

Categories

(WebExtensions :: Untriaged, defect, P5)

defect

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: emilio)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file)

Filed by: opoprus [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=299059693&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fsw_nJ7ZRtuVXtSWee70Yg/runs/0/artifacts/public/logs/live_backing.log


TEST-START | browser/components/extensions/test/browser/browser_ext_tabs_zoom.js

[task 2020-04-23T17:52:56.698Z] 17:52:56 INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_tabs_zoom.js | Got expected zoom value from parent - Expected: 1, Actual: 1 -
[task 2020-04-23T17:52:56.699Z] 17:52:56 INFO - Buffered messages finished
[task 2020-04-23T17:52:56.705Z] 17:52:56 INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_zoom.js | Got expected zoom event tab ID - Expected: 702, Actual: 703 -
[task 2020-04-23T17:52:56.706Z] 17:52:56 INFO - Stack trace:
[task 2020-04-23T17:52:56.706Z] 17:52:56 INFO - chrome://mochikit/content/browser-test.js:test_ok:1269
[task 2020-04-23T17:52:56.707Z] 17:52:56 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testHandler:68
[task 2020-04-23T17:52:56.707Z] 17:52:56 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:testResult:82
[task 2020-04-23T17:52:56.708Z] 17:52:56 INFO - resource://specialpowers/SpecialPowersChild.jsm:listener:2075
[task 2020-04-23T17:52:56.709Z] 17:52:56 INFO - resource://specialpowers/SpecialPowersChild.jsm:loadExtension/<:2017
[task 2020-04-23T17:52:56.709Z] 17:52:56 INFO - resource://specialpowers/SpecialPowersChild.jsm:receiveMessage:238
[task 2020-04-23T17:52:56.710Z] 17:52:56 INFO - JSWindowActor queryresource://specialpowers/SpecialPowersParent.jsm:resultListener:982
[task 2020-04-23T17:52:56.710Z] 17:52:56 INFO - resource://gre/modules/ExtensionCommon.jsm:emit:327
[task 2020-04-23T17:52:56.711Z] 17:52:56 INFO - resource://gre/modules/Extension.jsm:receiveMessage:1951
[task 2020-04-23T17:52:56.711Z] 17:52:56 INFO - MessageListener.receiveMessage
resource://gre/modules/Extension.jsm:Extension:1771
[task 2020-04-23T17:52:56.712Z] 17:52:56 INFO - resource://testing-common/ExtensionTestCommon.jsm:generate:458
[task 2020-04-23T17:52:56.712Z] 17:52:56 INFO - resource://specialpowers/SpecialPowersParent.jsm:receiveMessage:979
[task 2020-04-23T17:52:56.713Z] 17:52:56 INFO - JSWindowActor query*resource://specialpowers/SpecialPowersChild.jsm:loadExtension:2067
[task 2020-04-23T17:52:56.713Z] 17:52:56 INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension:113
[task 2020-04-23T17:52:56.714Z] 17:52:56 INFO - chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_tabs_zoom.js:test_zoom_api:249
[task 2020-04-23T17:52:56.714Z] 17:52:56 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1039
[task 2020-04-23T17:52:56.715Z] 17:52:56 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1074
[task 2020-04-23T17:52:56.715Z] 17:52:56 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:904
[task 2020-04-23T17:52:56.716Z] 17:52:56 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918

Flags: needinfo?(emilio)
Summary: Intermittent browser/components/extensions/test/browser/browser_ext_tabs_zoom.js | Got expected zoom event tab ID - Expected: "x", Actual: "y"- → Intermittent very frequent browser/components/extensions/test/browser/browser_ext_tabs_zoom.js | Got expected zoom event tab ID - Expected: "x", Actual: "y"-

This test was already a bit flaky it seems, see bug 1630399 for example.

But it has become much worse with my Fission zoom changes in bug 1612068, which
made the FullZoomChange events that this API relies on more async.

Properly wait for an event for the right tab instead of assuming that the last
zoom event was for the tab we happen to be waiting on.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93842a33d01a
Fix flakyness in browser_ext_tabs_zoom.js r=aswan
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.