1632670 - [wpt-sync] Sync PR 23217 - [EventTiming] Attempt to fix some flaky tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23217 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23217
Details from upstream follow.

Nicolás Peña Moreno <[e-mail]> wrote:

[EventTiming] Attempt to fix some flaky tests

This CL attempts to fix test flakiness.

• For the click counts, remove tests about mouseout/mouseover since
  those could fail under certain starting positions of the mouse, and
  the test has a pretty high flakiness score right now.
• For other tests, fix flakiness by making sure that PerformanceObserver
  callbacks where mousedown is not present are ignored. This is possible
  since a click triggers mousedown, mouseup, click, etc., so we cannot
  just assume that mousedown will always be present at the callback.

Bug: 1074048
Change-Id: I95a082948c105cf18b51376c9d6421195b23b718
Reviewed-on: https://chromium-review.googlesource.com/2163775
WPT-Export-Revision: 2bad9e81b17c5ab81c5810c2bb044ef279b34911

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 23217 applied with additional changes from upstream: 67f7dd268503f106abdc8b38f617a4ba2f299f95, bc01db77c4d739582f51c3b418037ae410116b06

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0806f89f14225d8471e7869e52b6d96d0cd69852

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 70 tests

Status Summary

Firefox

OK : 6
PASS : 64
FAIL : 6

Chrome

OK : 2
PASS : 2
TIMEOUT: 8

Safari

OK : 6
FAIL : 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/event-timing/crossiframe.html
Event Timing: entries should only be observable by its own frame.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/event-click-counts.html
Event Timing: eventCounts.: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/retrievability.html
Event Timing: make sure event-timing entries are not retrievable by performance.getEntries*.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/programmatic-click-not-observed.html
Event Timing: events from programmatic click are not observed: FAIL (Chrome: PASS, Safari: FAIL)
/event-timing/event-retarget.html
Event Timing: target reports the last Event Target, i.e. nothing from shadow DOM.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
/event-timing/timingconditions.html
Event Timing only times certain types of trusted event.: FAIL (Chrome: TIMEOUT, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19c25b37bca1
[wpt PR 23217] - [EventTiming] Attempt to fix some flaky tests, a=testonly

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/19c25b37bca1