Closed
Bug 1632706
Opened 5 years ago
Closed 5 years ago
AccGroupInfo need not query states on a sibling if it has cached AccGroupInfo
Categories
(Core :: Disability Access APIs, enhancement, P3)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Discovered when prototyping a fix for bug 1627073. When AccGroupInfo walks siblings, it skips siblings which have the INVISIBLE state. However, if the sibling has cached AccGroupInfo, we already know it's visible, so we don't need to query states.
I don't see an observable perf improvement with this change, but some instrumentation shows that we're definitely querying visibility less, which can only be a good thing.
|
Assignee | |
Comment 1•5 years ago
|
||
This avoids unnecessary calls to States().
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/020f48e9587e
When updating AccGroupInfo, If a sibling has cached group info, assume it's visible. r=MarcoZ
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•