1632730 - Graph Y axis labels are truncated

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Mike Hommey [:glandium] OoO until aug 27]

See https://treeherder.mozilla.org/perf.html#/graphs?highlightAlerts=1&selected=1921101,1115735113&series=autoland,1921056,1,2&series=autoland,1921101,1,2&timerange=1209600

The labels are actually starting from 106,000,000, but the 1 is hidden.

Comment 1

[Kimberly Sereduck :kimberlythegeek]

Could you attach a screenshot and/or steps to reproduce? I'm not seeing the same thing on my end.

Comment 2

[Mike Hommey [:glandium] OoO until aug 27]

Attachment: Screenshot

Comment 4

[Acasandrei Beatrice (needinfo me)]

I can confirm that this bug is still reproducing. The minimum length of the labels should be at least 11 characters (excluding the floating point).

Comment 5

[Acasandrei Beatrice (needinfo me)]

Could you please let me know which kind of approach I should consider in fixing this bug?

Comment 6

[Kimberly Sereduck :kimberlythegeek]

We could represent the numbers in a different way, such that 100,000 becomes 100k? I'm not sure what to use to denote millions. Or we could use units of measurement, milliseconds, seconds, etc?

Comment 7

[Sarah Clements [:sclements]]

(In reply to Acasandrei Beatrice from comment #5)

Could you please let me know which kind of approach I should consider in fixing this bug?

Interesting, I'm not able to reproduce that - even when adjusting for different screen sizes.

This is where the left padding is calculated: https://github.com/mozilla/treeherder/blob/master/ui/perfherder/graphs/GraphsContainer.jsx#L243

But I wonder if this is a CSS/media query issue?

Mike, Beatrice when specifically are you seeing this? What device/screen size? Any page zooming involved?

Comment 8

[Ionuț Goldan [:igoldan]]

(In reply to Kimberly Sereduck :kimberlythegeek from comment #6)

We could represent the numbers in a different way, such that 100,000 becomes 100k? I'm not sure what to use to denote millions. Or we could use units of measurement, milliseconds, seconds, etc?

Indeed, this could be an option. I see we use the numeral package, which can do this kind of thing. I believe the formatting feature is called abbreviation.
E.g. for number 1460 with format '0 a', we'd get 1 K.

Comment 9

[Ionuț Goldan [:igoldan]]

(In reply to Acasandrei Beatrice from comment #4)

I can confirm that this bug is still reproducing. The minimum length of the labels should be at least 11 characters (excluding the floating point).

Talking with Beatrice, we realized we haven't properly tested the Graphs view for these big values.
After a 2nd look, it seems the bug isn't reproducing. At least, not for the kind of data :glandium presented (series from build_metrics, on Windows & Linux platforms).

:glandium, are you ok with closing this as WORKSFORME? Or have you still encountered this bug lately?

Comment 10

[Mike Hommey [:glandium] OoO until aug 27]

I've seen this a few weeks ago.

Comment 11

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/7018