Graph Y axis labels are truncated
Categories
(Tree Management :: Perfherder, defect, P1)
Tracking
(Not tracked)
People
(Reporter: glandium, Assigned: bacasandrei)
References
()
Details
Attachments
(2 files)
The labels are actually starting from 106,000,000
, but the 1 is hidden.
Comment 1•4 years ago
|
||
Could you attach a screenshot and/or steps to reproduce? I'm not seeing the same thing on my end.
Reporter | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
I can confirm that this bug is still reproducing. The minimum length of the labels should be at least 11 characters (excluding the floating point).
Assignee | ||
Comment 5•4 years ago
|
||
Could you please let me know which kind of approach I should consider in fixing this bug?
Comment 6•4 years ago
|
||
We could represent the numbers in a different way, such that 100,000 becomes 100k? I'm not sure what to use to denote millions. Or we could use units of measurement, milliseconds, seconds, etc?
Comment 7•4 years ago
|
||
(In reply to Acasandrei Beatrice from comment #5)
Could you please let me know which kind of approach I should consider in fixing this bug?
Interesting, I'm not able to reproduce that - even when adjusting for different screen sizes.
This is where the left padding is calculated: https://github.com/mozilla/treeherder/blob/master/ui/perfherder/graphs/GraphsContainer.jsx#L243
But I wonder if this is a CSS/media query issue?
Mike, Beatrice when specifically are you seeing this? What device/screen size? Any page zooming involved?
Comment 8•4 years ago
•
|
||
(In reply to Kimberly Sereduck :kimberlythegeek from comment #6)
We could represent the numbers in a different way, such that 100,000 becomes 100k? I'm not sure what to use to denote millions. Or we could use units of measurement, milliseconds, seconds, etc?
Indeed, this could be an option. I see we use the numeral package, which can do this kind of thing. I believe the formatting feature is called abbreviation.
E.g. for number 1460 with format '0 a', we'd get 1 K.
Updated•4 years ago
|
Comment 9•4 years ago
•
|
||
(In reply to Acasandrei Beatrice from comment #4)
I can confirm that this bug is still reproducing. The minimum length of the labels should be at least 11 characters (excluding the floating point).
Talking with Beatrice, we realized we haven't properly tested the Graphs view for these big values.
After a 2nd look, it seems the bug isn't reproducing. At least, not for the kind of data :glandium presented (series from build_metrics, on Windows & Linux platforms).
:glandium, are you ok with closing this as WORKSFORME? Or have you still encountered this bug lately?
Updated•4 years ago
|
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Description
•