Closed Bug 1632735 Opened 5 years ago Closed 4 years ago

(rust 1.43) TEST-UNEXPECTED-FAIL | valgrind-test | Conditional jump or move depends on uninitialised value(s) at selectors::parser::parse_one_simple_selector

Categories

(Firefox Build System :: Toolchains, defect, P3)

Product:
Firefox Build System
Component:
Toolchains
Type:
defect

Tracking

(firefox79 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Bug 1632735 - Upgrade valgrind builds to the same rust version as other builds.
47 bytes, text/x-phabricator-request
Details | Review

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=299155100&revision=e99213a03beaff28e70ccda195351d33f45c5f22

[task 2020-04-24T03:04:20.957Z] 03:04:20     INFO -   1:42.23 ==11496==    by 0x103379B8: XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*)+616 (checkouts/gecko/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:947)
[task 2020-04-24T03:04:20.957Z] 03:04:20     INFO -   1:42.23 ==11496==    by 0x133432DA: CallJSNative (checkouts/gecko/js/src/vm/Interpreter.cpp:492)
[task 2020-04-24T03:04:20.957Z] 03:04:20     INFO -   1:42.23 ==11496==    by 0x133432DA: js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason)+874 (checkouts/gecko/js/src/vm/Interpreter.cpp:584)
[task 2020-04-24T03:04:20.957Z] 03:04:20     INFO -   1:42.23 ==11496==    by 0x1333C818: InternalCall (checkouts/gecko/js/src/vm/Interpreter.cpp:647)
[task 2020-04-24T03:04:20.957Z] 03:04:20     INFO -   1:42.23 ==11496==    by 0x1333C818: CallFromStack (checkouts/gecko/js/src/vm/Interpreter.cpp:651)
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23 ==11496==    by 0x1333C818: Interpret(JSContext*, js::RunState&)+36856 (checkouts/gecko/js/src/vm/Interpreter.cpp:3322)
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23 ==11496==  Uninitialised value was created by a stack allocation
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23 ==11496==    at 0x142A94CC: selectors::parser::parse_one_simple_selector+12 (parser.rs:2229)
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23 ==11496==
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23 {
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    <insert_a_suppression_name_here>
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    Memcheck:Cond
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    fun:_ZN9selectors6parser25parse_one_simple_selector17h1d03d5a40cf68d0fE
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    fun:_ZN9selectors6parser14parse_selector17hf53e13d8a2208dc9E
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    fun:_ZN9selectors6parser24SelectorList$LT$Impl$GT$5parse17h5abeca437985d25aE
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    fun:_ZN9cssparser22rules_and_declarations20parse_qualified_rule17h13672c7770f7b7abE
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    fun:_ZN5style11stylesheets10stylesheet18StylesheetContents8from_str17ha2e7e16d4dd98921E
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    fun:Servo_StyleSheet_FromUTF8Bytes
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla10StyleSheet14ParseSheetSyncEPNS_3css6LoaderERK12nsTSubstringIcEPNS1_13SheetLoadDataEjPNS1_25LoaderReusableStyleSheetsE
[task 2020-04-24T03:04:20.958Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla3css6Loader10ParseSheetERK12nsTSubstringIcERNS0_13SheetLoadDataENS1_15AllowAsyncParseE
[task 2020-04-24T03:04:20.959Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla3css12StreamLoader13OnStopRequestEP10nsIRequest8nsresult
[task 2020-04-24T03:04:20.959Z] 03:04:20     INFO -   1:42.23    fun:_ZN17nsSyncLoadService24PushSyncStreamToListenerE16already_AddRefedI14nsIInputStreamEP17nsIStreamListenerP10nsIChannel
[task 2020-04-24T03:04:20.959Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla3css6Loader9LoadSheetERNS0_13SheetLoadDataENS1_10SheetStateENS1_9IsPreloadE
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla3css6Loader28InternalLoadNonDocumentSheetEP6nsIURINS1_9IsPreloadENS0_16SheetParsingModeENS1_18UseSystemPrincipalEP12nsIPrincipalPKNS_8EncodingEP15nsIReferrerInfoP20nsICSSLoaderObserverNS_8CORSModeERK12nsTSubstringIDsE
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla3css6Loader13LoadSheetSyncEP6nsIURINS0_16SheetParsingModeENS1_18UseSystemPrincipalE
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla21GlobalStyleSheetCache9LoadSheetEP6nsIURINS_3css16SheetParsingModeENS3_13FailureActionE
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:LoadSheetURL
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla21GlobalStyleSheetCache8XULSheetEv
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla21GlobalStyleSheetCacheC1Ev
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla21GlobalStyleSheetCache9SingletonEv
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla3dom8Document27FillStyleSetUserAndUASheetsEv
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:FillStyleSet
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN7mozilla3dom8Document15CreatePresShellEP13nsPresContextP13nsViewManager
[task 2020-04-24T03:04:20.960Z] 03:04:20     INFO -   1:42.23    fun:_ZN16nsDocumentViewer21InitPresentationStuffEb
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN16nsDocumentViewer12InitInternalEP9nsIWidgetP11nsISupportsPN7mozilla3dom17WindowGlobalChildERKNS4_3gfx12IntRectTypedINS8_12UnknownUnitsEEEbbb
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN16nsDocumentViewer4InitEP9nsIWidgetRKN7mozilla3gfx12IntRectTypedINS3_12UnknownUnitsEEEPNS2_3dom17WindowGlobalChildE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN10nsDocShell14SetupNewViewerEP16nsIContentViewerPN7mozilla3dom17WindowGlobalChildE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN10nsDocShell5EmbedEP16nsIContentViewerPN7mozilla3dom17WindowGlobalChildE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN10nsDocShell29CreateAboutBlankContentViewerEP12nsIPrincipalS1_P24nsIContentSecurityPolicyP6nsIURIbbPN7mozilla3dom17WindowGlobalChildE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN10nsDocShell29CreateAboutBlankContentViewerEP12nsIPrincipalS1_P24nsIContentSecurityPolicy
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN17nsAppShellService19JustCreateTopWindowEP12nsIAppWindowP6nsIURIjiibPPN7mozilla9AppWindowE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN17nsAppShellService20CreateTopLevelWindowEP12nsIAppWindowP6nsIURIjiiPS1_
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN12nsAppStartup18CreateChromeWindowEP19nsIWebBrowserChromejP17nsIOpenWindowInfoPbPS1_
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:CreateChromeWindow
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN15nsWindowWatcher18OpenWindowInternalEP18mozIDOMWindowProxyPKcS3_S3_bbbP8nsIArraybbbP19nsDocShellLoadStatePPN7mozilla3dom15BrowsingContextE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN15nsWindowWatcher10OpenWindowEP18mozIDOMWindowProxyPKcS3_S3_P11nsISupportsPS1_
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    obj:/builds/worker/workspace/obj-build/toolkit/library/build/libxul.so
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:Invoke
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:Call
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN16XPCWrappedNative10CallMethodER14XPCCallContextNS_8CallModeE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_Z17XPC_WN_CallMethodP9JSContextjPN2JS5ValueE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:CallJSNative
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructENS_10CallReasonE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:InternalCall
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:CallFromStack
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23    fun:_ZL9InterpretP9JSContextRN2js8RunStateE
[task 2020-04-24T03:04:20.961Z] 03:04:20     INFO -   1:42.23 }

Julian, would you mind checking this out?

Flags: needinfo?(jseward)
Priority: -- → P3

And add suppressions for the new errors that this adds to the valgrind
run. It's not clear if it's a legitimate thing that LLVM does that
valgrind doesn't cope with, like many others, but the fact is running
valgrind on a PGO/LTO build doesn't show these errors, so we're not
actually shipping them anyways (but does show different errors that we
don't see on the build the valgrind jobs do)

Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Blocks: 1648343
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/e7e487fbbaf0
Upgrade valgrind builds to the same rust version as other builds. r=erahm

https://hg.mozilla.org/mozilla-central/rev/e7e487fbbaf0

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Flags: needinfo?(jseward)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: