Closed
Bug 1632805
Opened 4 years ago
Closed 4 years ago
ModalPrompter falls back to window prompts for subframe BrowsingContexts
Categories
(Firefox :: Security, defect, P1)
Firefox
Security
Tracking
()
RESOLVED
DUPLICATE
of bug 1631362
People
(Reporter: pbz, Assigned: pbz)
References
Details
Attachments
(1 obsolete file)
Currently, when prompting with a BC of a subframe, ModalPrompter will fail to get the window actor and fallback to a window prompt.
For example, running this on a page with an iframe will result in a window prompt:
Services.prompt.alertBC(gBrowser.selectedBrowser.browsingContext.children[0], Services.prompt.MODAL_TYPE_TAB, 'title', 'body')
Using the top browsing context here probably fixes this.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
I think this is a P1 and we should land it as soon as possible so this gets enough time in nightly.
|
||
Updated•4 years ago
|
Priority: -- → P1
Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/053cfd9fe86a ModalPrompter: Use top browsing context to support subframes. r=johannh
|
||
Updated•4 years ago
|
Severity: -- → normal
Fission Milestone: --- → M6a
|
||
Comment 4•4 years ago
|
||
Backed out for
Backout link: https://hg.mozilla.org/integration/autoland/rev/21c4b1811282437e3e6cb655ee464ca799cb6071
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300336660&repo=autoland&lineNumber=14224
Flags: needinfo?(pbz)
|
||
Updated•4 years ago
|
Attachment #9143059 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•4 years ago
|
||
The patch for Bug 1631362 fixes this.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(pbz)
Resolution: --- → DUPLICATE
|
|
||
Comment 6•4 years ago
|
||
Clearing Fission Milestone for bugs resolved as duplicates. We don't need to track duplicates.
Fission Milestone: M6a → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•