Closed
Bug 1632846
Opened 4 years ago
Closed 4 years ago
Reduce per-slice GC overhead from marking auto rooters
Categories
(Core :: JavaScript: GC, task, P1)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla77
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(2 files)
Some auto rooters get marked on every GC slice, but there are some things we can do to optimise this. For example, it's not necessary to mark a value more than once in the same GC.
Some background as to why we do this: https://searchfox.org/mozilla-central/source/js/src/vm/Compartment.h#453-467
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D72594
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a6ba189ebea3 Split auto rooter list into separate lists for each kind so we can only trace the onse we care about r=sfink https://hg.mozilla.org/integration/autoland/rev/5a1cc6933977 Refactor auto rooter tracing so we can more easily convert these to use Rooted<> instead r=sfink
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a6ba189ebea3
https://hg.mozilla.org/mozilla-central/rev/5a1cc6933977
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•