1632846 - Reduce per-slice GC overhead from marking auto rooters

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Jon Coppeard (:jonco)]

Some auto rooters get marked on every GC slice, but there are some things we can do to optimise this. For example, it's not necessary to mark a value more than once in the same GC.

Some background as to why we do this: https://searchfox.org/mozilla-central/source/js/src/vm/Compartment.h#453-467

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1632846 - Split auto rooter list into separate lists for each kind so we can only trace the onse we care about r?sfink

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1632846 - Refactor auto rooter tracing so we can more easily convert these to use Rooted<> instead r?sfink

Depends on D72594

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6ba189ebea3
Split auto rooter list into separate lists for each kind so we can only trace the onse we care about r=sfink
https://hg.mozilla.org/integration/autoland/rev/5a1cc6933977
Refactor auto rooter tracing so we can more easily convert these to use Rooted<> instead r=sfink

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a6ba189ebea3
https://hg.mozilla.org/mozilla-central/rev/5a1cc6933977