1632854 - The about:preferences#privacy page hangs if the “Use a master password” checkbox gets ticked/unticked a couple of times while the OS auth dialog is displayed

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: mp.gif

Affected versions

• Firefox 76.0b8 (BuildId:20200424000239)
• Firefox 77.0a1 (BuildId:20200424114754)

Affected platforms

• Windows 10 64bit
• macOS 10.14.5

Preconditions

• Have an OS password set.

Steps to reproduce

1. Launch Firefox.
2. Access the about:preferences#privacy page.
3. Tick the “Use a master password checkbox”
4. Ignore the OS auth prompt and tick/untick the “Use a master password” checkbox a couple of times.
5. Introduce the correct OS password inside the OS auth prompt.
6. Set a master password.
7. Interact with the about:preferences#privacy page.

Expected result

• The about:preferences#privacy page can be interacted with.

Actual result

• The about:preferences#privay page gets frozen and the browser console outputs the following errors:
  InternalError: too much recursion
TypeError: this.webNavigation is null

Notes

• It seems that a simple page refresh solves this issue.
• For further information regarding this issue please observe the attached screencast.

Comment 1

[Matthew N. [:MattN]]

I thought the OS auth prompt was supposed to be window modal… you shouldn't be able to complete step 4 without closing the dialog… did bug 1506602 not fix that on Windows? IIRC we couldn't fix bug 1506602 for macOS so this problem would still apply there.

Comment 2

[Emil Ghitta, QA [:emilghitta]]

The OS auth prompt seems to act as modeless if triggered from the "Use a master password" checkbox (from the about:preferences#privacy page). I can reproduce this behavior using latest versions of Firefox...so it seems that Bug 1506602 didn't fixed this behavior here.

It seems that the verification in Bug 1506602 was performed for the about:logins page (per Comment 12)

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1632854 - Pass the ChromeWindow reference to the OSKeyStore instead of the content global so the dialog will be app modal. r?MattN

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2569411eb193
Pass the ChromeWindow reference to the OSKeyStore instead of the content global so the dialog will be app modal. r=MattN

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2569411eb193

Comment 6

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 78.0a1 (BuildId:20200505213825) and Firefox 77.0b2 (BuildID:20200505174119) on Windows 10 64bit.

The OS auth prompt is now modal for the about:preferences#privacy page. This issue still affects macOS but per Bug 1623109 (Comment 7) there is not much that we can do for now.

Closing this as verified fixed.