1632874 - Mach bootstrap should write the mozconfig file for you if no such file exists and no MOZCONFIG env var is set and the user chooses a setup option that requires custom build options

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement, P3)

Description

[:Gijs (he/him)]

Some students Mike and I mentored gave us feedback about this, and I've seen other people I've mentored in the past tell me they definitely were using artifact builds... and they weren't.

If there is no existing file and no env var set, and we're run from the source dir, it seems safe to create such a file (and tell the user it's been created).

Comment 1

[:Gijs (he/him)]

Clarifying the summary a bit. AIUI, we'd be wanting to write the mozconfig for both types of artifact builds as well as geckoview non-artifact builds.

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1632874: |mach bootstrap| should write mozconfig file if it doesn't exist r?rstewart

Rather than always printing instructions at the end of the bootstrap phase, we will now create a mozconfig
file if one doesn't exist and there's configuration to be written.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9c52538d77d
|mach bootstrap| should write mozconfig file if it doesn't exist r=rstewart

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c9c52538d77d

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1632874: Update docs since mozconfig file is automatically created r?agi

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbd35ab77253
Update docs since mozconfig file is automatically created r=agi,geckoview-reviewers

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cbd35ab77253