Closed Bug 1632985 Opened 4 years ago Closed 4 years ago

Check existing tests in ToolbarPanelHub for inconsistencies

Categories

(Firefox :: Messaging System, task, P2)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 78
Iteration:
78.1 - May 4 - May 17
Tracking Flags:
Tracking Status
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- fixed

People

(Reporter: emcminn, Assigned: emcminn)

References

Details

Attachments

(1 file)

Bug 1632985 - Fixes for ToolbarPanelHub tests
47 bytes, text/x-phabricator-request
Details | Review

A test needs to be added to ToolbarPanelHub.test.js to cover the new toggleWhatsNewPref function. EDIT: This test has been added to 1599138. Some loopholes/inconsistencies in the existing tests were turned up by the new functionality; these should also be reviewed and fixed if necessary.

Blocks: 1599138
Iteration: --- → 77.2 - Apr 20 - May 3
status-firefox77: --- → affected
No longer depends on: 1599138
Priority: -- → P1
Summary: Improve unit test coverage of ToolbarPanelHub, and check existing tests → Check existing tests in ToolbarPanelHub for inconsistencies
Priority: P1 → P2
Iteration: 77.2 - Apr 20 - May 3 → 78.1 - May 4 - May 17
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60588daabc7a
Fixes for ToolbarPanelHub tests r=k88hudson

https://hg.mozilla.org/mozilla-central/rev/60588daabc7a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: