Closed Bug 1633093 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23248 - Enable feature detection of declarative Shadow DOM

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23248 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23248
Details from upstream follow.

Mason Freed <masonfreed@chromium.org> wrote:

Enable feature detection of declarative Shadow DOM

To enable feature detection, this CL enables this:

HTMLTemplateElement.prototype.hasOwnProperty("shadowRoot")

This is as documented in the explainer, at [1].

[1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#feature-detection-and-polyfilling

Bug: 1042130
Change-Id: I529af9ce952b4d2e162e099c7ca703af8f3c4791
Reviewed-on: https://chromium-review.googlesource.com/2166466
WPT-Export-Revision: ebed5d40d3eb7504a1932bd7d27ec24f1465e4c9

PR 23248 applied with additional changes from upstream: f8bfad9f31e64b909d850df59202a02edb3d89ac, 13868f2aa3ff16f7f338d492e0027c301f07f74c
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 68 tests

Status Summary

Firefox

OK : 1
PASS : 3[GitHub] 67[Gecko-android-em-7.0-x86_64-debug-geckoview] 68[Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL : 7

Chrome

CRASH: 1

Safari

OK : 1
PASS : 3
FAIL : 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/shadow-dom/declarative/declarative-shadow-dom-basic.tentative.html
Declarative Shadow DOM: Missing closing tag: FAIL (Safari: FAIL)
Declarative Shadow DOM: Fragment parser basic test: FAIL (Safari: FAIL)
Declarative Shadow DOM: delegates focus attribute: FAIL (Safari: FAIL)
Declarative Shadow DOM: Multiple roots: FAIL (Safari: FAIL)
Declarative Shadow DOM: Closed shadow root attribute: FAIL (Safari: FAIL)
Declarative Shadow DOM: Feature detection: FAIL (Safari: FAIL)
Declarative Shadow DOM: Basic test: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/feacc4aa4e4d [wpt PR 23248] - Enable feature detection of declarative Shadow DOM, a=testonly https://hg.mozilla.org/integration/autoland/rev/ef50e02e0c55 [wpt PR 23248] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.