Closed Bug 1633119 Opened 5 years ago Closed 4 years ago

Fullscreen window opened by script leaves a fake toolbar on the top of screen with full-screen-api.macos-native-full-screen enabled

Categories

(Core :: Widget: Cocoa, defect, P2)

Product:
Core
Component:
Widget: Cocoa
Platform:
Unspecified
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- verified

People

(Reporter: xidorn, Assigned: xidorn, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mac:fullscreen] )

Attachments

(3 files)

testcase
171 bytes, text/html
Details
Bug 1633119 - Use orderFront for force window full screen. r?spohl
47 bytes, text/x-phabricator-request
Details | Review
Bug 1633119 - Remove `customWindows[...]` methods. r=#mac-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Attached file testcase —

Steps to reproduce:

  1. open the attached testcase
  2. click the button "Open Window"
  3. click the green full screen button on the top left corner of the new window

Expected result:
the address bar should be on the top of the screen

Actual result:
there is a grey bar, seemingly a fake title bar

This affects using native full screen for Fullscreen API on macOS because many fullscreen tests take the assumption that the window is actually in fullscreen state only when the window size matches the screen size. But this fake title bar makes it never happen.

I had a look at this issue, and it seems that the fake title bar is not from the chrome area either, i.e. the privilege chrome document is smaller than fullscreen as well in that case. So there is probably something going wrong with the widget window.

spohl, do you have thought on what could be going wrong here?

Blocks: 1631735
Flags: needinfo?(spohl.mozilla.bugs)

I don't know off-hand, but will try to take a look next week. Leaving n-i set.

Priority: -- → P2

Hmm, I just tried to find when this might have started using mozregression, but I found that I can't reproduce. I then tried a new profile with the same Firefox build where I could reproduce this issue before, and I'm unable to reproduce there either. Xidorn, can you verify that you still see this with a new profile?

Flags: needinfo?(spohl.mozilla.bugs) → needinfo?(xidorn+moz)

Oh, so this only happens when full-screen-api.macos-native-full-screen is set to true, and the reason seems to be customWindowsToEnterFullScreenForWindow: which was added for making the window skip transition and jump instant to full screen.

I have sent an email to a Chromium developer to ask about how they achieve their behavior, as I'm not seeing them using this method. Hopefully there could be a path forward without using the custom window stuff.

Flags: needinfo?(xidorn+moz)
Assignee: nobody → xidorn+moz
Summary: Fullscreen window opened by script leaves a fake toolbar on the top of screen → Fullscreen window opened by script leaves a fake toolbar on the top of screen with full-screen-api.macos-native-full-screen enabled

The Chromium developer replied me that calling [window orderOut:nil] before [window toggleFullScreen:nil] and [window orderFront:nil] after would do the trick, but based on my experiment, doing [window orderFront:nil] is enough, and adding [window orderOut:nil] would actually cause more problems for us.

Pushed by mozilla@upsuper.org: https://hg.mozilla.org/integration/autoland/rev/78ed541858a2 Use orderFront for force window full screen. r=spohl

Backed out changeset 78ed541858a2 (bug 1633119) for browser_panelUINotifications* failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2Cmochitests&fromchange=78ed541858a26f7ebfe55eb05db9c7b1871fc9ba&tochange=1a1b335e450eefc2e91fda7edcaa7be9d9877ac6&selectedTaskRun=QWCPLhonSbKhxfwT_bSmwA-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/1a1b335e450eefc2e91fda7edcaa7be9d9877ac6

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301551017&repo=autoland&lineNumber=8980

[task 2020-05-09T13:11:51.760Z] 13:11:51     INFO - TEST-START | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js
[task 2020-05-09T13:11:52.275Z] 13:11:52     INFO - GECKO(1903) | JavaScript error: resource://gre/modules/URIFixup.jsm, line 207: NS_ERROR_FAILURE: Should pass a non-null uri
[task 2020-05-09T13:11:52.646Z] 13:11:52     INFO - GECKO(1903) | 2020-05-09 13:11:52.620 firefox[1903:11684] not in fullscreen state
[task 2020-05-09T13:11:52.772Z] 13:11:52     INFO - GECKO(1903) | [Parent 1903, Main Thread] WARNING: 'mChromeFields.mFullscreenPresShell', file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp, line 4675
[task 2020-05-09T13:11:53.168Z] 13:11:53     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x147a0a400) [pid = 1906] [serial = 200] [outer = 0x0] [url = about:blank]
...
...
[task 2020-05-09T13:12:03.484Z] 13:12:03     INFO - GECKO(1903) | [Parent 1903: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x129da7000) [pid = 1903] [serial = 244] [outer = 0x0] [url = about:addons]
[task 2020-05-09T13:13:21.880Z] 13:13:21     INFO - TEST-INFO | started process screencapture
[task 2020-05-09T13:13:21.990Z] 13:13:21     INFO - TEST-INFO | screencapture: exit 0
[task 2020-05-09T13:13:21.990Z] 13:13:21     INFO - Buffered messages logged at 13:11:51
[task 2020-05-09T13:13:21.990Z] 13:13:21     INFO - Entering test bound testFullscreen
[task 2020-05-09T13:13:21.991Z] 13:13:21     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | update-manual doorhanger is closed. - 
[task 2020-05-09T13:13:21.991Z] 13:13:21     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | update-manual doorhanger is showing. - 
[task 2020-05-09T13:13:21.991Z] 13:13:21     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | PanelUI doorhanger is only displaying one notification. - 
[task 2020-05-09T13:13:21.991Z] 13:13:21     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | PanelUI is displaying the update-manual notification. - 
[task 2020-05-09T13:13:21.992Z] 13:13:21     INFO - Buffered messages logged at 13:11:52
[task 2020-05-09T13:13:21.992Z] 13:13:21     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | update-manual doorhanger is still showing after entering fullscreen. - 
[task 2020-05-09T13:13:21.992Z] 13:13:21     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | update-manual doorhanger is hidden after entering DOM fullscreen. - 
[task 2020-05-09T13:13:21.998Z] 13:13:21     INFO - Console message: [JavaScript Error: "NS_ERROR_FAILURE: Should pass a non-null uri" {file: "resource://gre/modules/URIFixup.jsm" line: 207}]
[task 2020-05-09T13:13:21.998Z] 13:13:21     INFO - getFixupURIInfo@resource://gre/modules/URIFixup.jsm:207:13
[task 2020-05-09T13:13:21.998Z] 13:13:21     INFO - _getUrlMetaData@resource:///modules/UrlbarValueFormatter.jsm:131:35
[task 2020-05-09T13:13:21.998Z] 13:13:21     INFO - _ensureFormattedHostVisible/<@resource:///modules/UrlbarValueFormatter.jsm:86:41
[task 2020-05-09T13:13:21.998Z] 13:13:21     INFO - FrameRequestCallback*_ensureFormattedHostVisible@resource:///modules/UrlbarValueFormatter.jsm:76:17
[task 2020-05-09T13:13:21.998Z] 13:13:21     INFO - _on_resize/this._resizeThrottleTimeout<@resource:///modules/UrlbarValueFormatter.jsm:466:12
[task 2020-05-09T13:13:21.998Z] 13:13:21     INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:788:41
[task 2020-05-09T13:13:21.998Z] 13:13:21     INFO - _on_resize@resource:///modules/UrlbarValueFormatter.jsm:464:47
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - handleEvent@resource:///modules/UrlbarValueFormatter.jsm:448:23
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - EventListener.handleEvent*UrlbarValueFormatter@resource:///modules/UrlbarValueFormatter.jsm:38:17
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - UrlbarInput/<@resource:///modules/UrlbarInput.jsm:156:14
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - get@resource://gre/modules/XPCOMUtils.jsm:129:51
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - formatValue@resource:///modules/UrlbarInput.jsm:230:7
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - _on_focus@resource:///modules/UrlbarInput.jsm:1987:10
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - handleEvent@resource:///modules/UrlbarInput.jsm:372:23
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - EventListener.handleEvent*UrlbarInput/this[method]@resource:///modules/UrlbarInput.jsm:134:39
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - UrlbarInput@resource:///modules/UrlbarInput.jsm:192:12
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - @chrome://browser/content/browser.js:325:16
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - get@resource://gre/modules/XPCOMUtils.jsm:129:51
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - _setInitialFocus/<@chrome://browser/content/browser.js:2133:9
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - _callWithURIToLoad@chrome://browser/content/browser.js:2409:15
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - _setInitialFocus@chrome://browser/content/browser.js:2131:10
[task 2020-05-09T13:13:21.999Z] 13:13:21     INFO - onDOMContentLoaded@chrome://browser/content/browser.js:1813:10
[task 2020-05-09T13:13:22.000Z] 13:13:21     INFO - EventListener.handleEvent*@chrome://browser/content/browser.xhtml:135:10
[task 2020-05-09T13:13:22.000Z] 13:13:21     INFO - 
[task 2020-05-09T13:13:22.000Z] 13:13:22     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | update-manual doorhanger is shown after exiting DOM fullscreen. - 
[task 2020-05-09T13:13:22.000Z] 13:13:22     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | Badge is not displaying on PanelUI button. - 
[task 2020-05-09T13:13:22.000Z] 13:13:22     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | Main action callback was called - 
[task 2020-05-09T13:13:22.001Z] 13:13:22     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | update-manual doorhanger is closed. - 
[task 2020-05-09T13:13:22.001Z] 13:13:22     INFO - TEST-PASS | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | Should not have a badge status - 
[task 2020-05-09T13:13:22.001Z] 13:13:22     INFO - Buffered messages finished
[task 2020-05-09T13:13:22.001Z] 13:13:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | Test timed out - 
[task 2020-05-09T13:13:22.001Z] 13:13:22     INFO - GECKO(1903) | MEMORY STAT | vsize 7894MB | residentFast 539MB | heapAllocated 145MB
[task 2020-05-09T13:13:22.002Z] 13:13:22     INFO - TEST-OK | browser/components/customizableui/test/browser_panelUINotifications_fullscreen_noAutoHideToolbar.js | took 90135ms
[task 2020-05-09T13:13:22.003Z] 13:13:22     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x145bab800 == 1 [pid = 1906] [id = {4871575e-6331-f740-b8db-08ee1b166c70}]
[task 2020-05-09T13:13:22.003Z] 13:13:22     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x11130b520) [pid = 1906] [serial = 207] [outer = 0x0]
[task 2020-05-09T13:13:22.003Z] 13:13:22     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x145bae000) [pid = 1906] [serial = 208] [outer = 0x11130b520]
[task 2020-05-09T13:13:22.004Z] 13:13:22     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x146793800) [pid = 1906] [serial = 209] [outer = 0x11130b520]
[task 2020-05-09T13:13:22.004Z] 13:13:22     INFO - checking window state
[task 2020-05-09T13:13:22.035Z] 13:13:22     INFO - TEST-START | browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js
[task 2020-05-09T13:13:22.068Z] 13:13:22     INFO - GECKO(1903) | [Child 1908: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x124854c00 == 1 [pid = 1908] [id = {60e53ef7-8eb9-a547-8fa1-146dca88d387}]
[task 2020-05-09T13:13:22.068Z] 13:13:22     INFO - GECKO(1903) | [Child 1908: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x11610b520) [pid = 1908] [serial = 41] [outer = 0x0]
[task 2020-05-09T13:13:22.068Z] 13:13:22     INFO - GECKO(1903) | [Child 1908: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x124857000) [pid = 1908] [serial = 42] [outer = 0x11610b520]
[task 2020-05-09T13:13:22.101Z] 13:13:22     INFO - GECKO(1903) | [Child 1908: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x12485c800) [pid = 1908] [serial = 43] [outer = 0x11610b520]
[task 2020-05-09T13:13:30.149Z] 13:13:30     INFO - GECKO(1903) | [Child 1905: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x14a67ac00 == 0 [pid = 1905] [id = {ce262487-cf9f-f742-851b-fcf61b90df35}] [url = about:blank]
[task 2020-05-09T13:13:34.442Z] 13:13:34     INFO - GECKO(1903) | [Child 1905: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0x10a70b6f0) [pid = 1905] [serial = 213] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:13:38.685Z] 13:13:38     INFO - GECKO(1903) | [Child 1905: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0x1436b0800) [pid = 1905] [serial = 216] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:14:30.257Z] 13:14:30     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x145bae000) [pid = 1906] [serial = 208] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:14:34.380Z] 13:14:34     INFO - GECKO(1903) | [Child 1908: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x124857000) [pid = 1908] [serial = 42] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:14:52.222Z] 13:14:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-09T13:14:52.222Z] 13:14:52     INFO - Buffered messages logged at 13:13:22
[task 2020-05-09T13:14:52.222Z] 13:14:52     INFO - Entering test bound testDoesNotShowDoorhangerForBackgroundWindow
[task 2020-05-09T13:14:52.222Z] 13:14:52     INFO - Buffered messages finished
[task 2020-05-09T13:14:52.222Z] 13:14:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js | Test timed out - 
[task 2020-05-09T13:14:52.261Z] 13:14:52     INFO - GECKO(1903) | MEMORY STAT | vsize 7890MB | residentFast 536MB | heapAllocated 149MB
[task 2020-05-09T13:14:52.261Z] 13:14:52     INFO - TEST-OK | browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js | took 90209ms
[task 2020-05-09T13:14:52.261Z] 13:14:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-09T13:14:52.261Z] 13:14:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js | Found a tab after previous test timed out: about:blank - 
[task 2020-05-09T13:14:52.291Z] 13:14:52     INFO - GECKO(1903) | [Child 1905: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x14351c400 == 1 [pid = 1905] [id = {0e4c1e0b-c48f-7048-9598-29ae21ce0dea}]
[task 2020-05-09T13:14:52.291Z] 13:14:52     INFO - GECKO(1903) | [Child 1905: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x10a70b520) [pid = 1905] [serial = 217] [outer = 0x0]
[task 2020-05-09T13:14:52.291Z] 13:14:52     INFO - GECKO(1903) | [Child 1905: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x14351d800) [pid = 1905] [serial = 218] [outer = 0x10a70b520]
[task 2020-05-09T13:14:52.313Z] 13:14:52     INFO - GECKO(1903) | [Child 1905: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x14a67cc00) [pid = 1905] [serial = 219] [outer = 0x10a70b520]
[task 2020-05-09T13:14:52.314Z] 13:14:52     INFO - checking window state
[task 2020-05-09T13:14:52.337Z] 13:14:52     INFO - TEST-START | browser/components/customizableui/test/browser_panel_keyboard_navigation.js
[task 2020-05-09T13:14:52.371Z] 13:14:52     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-09T13:14:52.371Z] 13:14:52     INFO - Buffered messages logged at 13:14:52
[task 2020-05-09T13:14:52.372Z] 13:14:52     INFO - Entering test bound testUpDownKeys
[task 2020-05-09T13:14:52.372Z] 13:14:52     INFO - TEST-PASS | browser/components/customizableui/test/browser_panel_keyboard_navigation.js | The panel is closed to begin with. - "closed" == "closed" - 
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - Buffered messages finished
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js:19 - TypeError: can't access property "openNewBrowserWindow", BrowserTestUtils is null
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - Stack trace:
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - testDoesNotShowDoorhangerForBackgroundWindow/<@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js:19:15
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - withNewTab@resource://testing-common/BrowserTestUtils.jsm:146:24
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - async*testDoesNotShowDoorhangerForBackgroundWindow@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_panelUINotifications_multiWindow.js:18:26
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1064:34
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:927:14
[task 2020-05-09T13:14:52.381Z] 13:14:52     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-05-09T13:15:00.391Z] 13:15:00     INFO - GECKO(1903) | [Child 1908: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x124854c00 == 0 [pid = 1908] [id = {60e53ef7-8eb9-a547-8fa1-146dca88d387}] [url = about:blank]
[task 2020-05-09T13:15:00.427Z] 13:15:00     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x145bab800 == 0 [pid = 1906] [id = {4871575e-6331-f740-b8db-08ee1b166c70}] [url = about:blank]
[task 2020-05-09T13:15:03.638Z] 13:15:03     INFO - Console message: [JavaScript Error: "Unknown Collection "main/messaging-experiments"" {file: "resource://services-settings/RemoteSettingsClient.jsm" line: 145}]
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - UnknownCollectionError@resource://services-settings/RemoteSettingsClient.jsm:145:5
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - sync@resource://services-settings/RemoteSettingsClient.jsm:407:13
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - async*get@resource://services-settings/RemoteSettingsClient.jsm:342:22
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - async*updateRecipes@resource://messaging-system/lib/RemoteSettingsExperimentLoader.jsm:141:49
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - setTimer/<@resource://messaging-system/lib/RemoteSettingsExperimentLoader.jsm:188:18
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - TM_notify/</<@resource://gre/modules/UpdateTimerManager.jsm:257:36
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - ChromeUtils::IdleDispatch handler*TM_notify/<@resource://gre/modules/UpdateTimerManager.jsm:255:25
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - TM_notify@resource://gre/modules/UpdateTimerManager.jsm:290:7
[task 2020-05-09T13:15:03.639Z] 13:15:03     INFO - 
[task 2020-05-09T13:15:04.750Z] 13:15:04     INFO - GECKO(1903) | [Child 1908: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0x11610b520) [pid = 1908] [serial = 41] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:15:04.778Z] 13:15:04     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0x11130b520) [pid = 1906] [serial = 207] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:15:08.981Z] 13:15:08     INFO - GECKO(1903) | [Child 1908: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0x12485c800) [pid = 1908] [serial = 43] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:15:08.981Z] 13:15:08     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0x146793800) [pid = 1906] [serial = 209] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:15:16.639Z] 13:15:16     INFO - GECKO(1903) | [Child 1905: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x14351d800) [pid = 1905] [serial = 218] [outer = 0x0] [url = about:blank]
[task 2020-05-09T13:16:22.362Z] 13:16:22     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-09T13:16:22.362Z] 13:16:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_panel_keyboard_navigation.js | Test timed out - 
[task 2020-05-09T13:16:22.362Z] 13:16:22     INFO - GECKO(1903) | MEMORY STAT | vsize 7890MB | residentFast 535MB | heapAllocated 151MB
[task 2020-05-09T13:16:22.363Z] 13:16:22     INFO - TEST-OK | browser/components/customizableui/test/browser_panel_keyboard_navigation.js | took 90024ms
task 2020-05-09T13:16:22.380Z] 13:16:22     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x145bac400 == 1 [pid = 1906] [id = {ae3b4989-5477-1d49-99e2-351f323c3822}]
[task 2020-05-09T13:16:22.380Z] 13:16:22     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x11130b520) [pid = 1906] [serial = 210] [outer = 0x0]
[task 2020-05-09T13:16:22.380Z] 13:16:22     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x145bae400) [pid = 1906] [serial = 211] [outer = 0x11130b520]
[task 2020-05-09T13:16:22.402Z] 13:16:22     INFO - GECKO(1903) | [Child 1906: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x146793c00) [pid = 1906] [serial = 212] [outer = 0x11130b520]
[task 2020-05-09T13:16:22.437Z] 13:16:22     INFO - checking window state
[task 2020-05-09T13:16:22.442Z] 13:16:22     INFO - TEST-START | browser/components/customizableui/test/browser_panel_toggle.js
[task 2020-05-09T13:16:22.471Z] 13:16:22     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-09T13:16:22.471Z] 13:16:22     INFO - Buffered messages logged at 13:16:22
[task 2020-05-09T13:16:22.471Z] 13:16:22     INFO - Entering test bound 
[task 2020-05-09T13:16:22.471Z] 13:16:22     INFO - Buffered messages finished
[task 2020-05-09T13:16:22.471Z] 13:16:22     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_panel_toggle.js | The panel is closed to begin with. - "showing" == "closed" - JS frame :: resource://testing-common/CustomizableUITestUtils.jsm :: openPanelMultiView :: line 68
[task 2020-05-09T13:16:22.471Z] 13:16:22     INFO - Stack trace:
...
...
...
Flags: needinfo?(xidorn+moz)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:xidorn, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(xidorn+moz)

Yes, I'll get back to this.

Flags: needinfo?(xidorn+moz)

Reminder to myself to check out what needs to be done to move this further.

Flags: needinfo?(mstange.moz)
Whiteboard: [mac:fullscreen]

I think the best way to move forward here would be to remove the customWindows[...] method and live with the slow transition. We can work on tightening up the transition later. In my testing with Chrome, Chrome also has the slow transition with paused drawing during the transition.

Flags: needinfo?(mstange.moz)

Try push with just Martin's patch to disable the animation without enabling native fullscreen.

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=FCL6O9PWQdK29ZNhxXuMWg.0&revision=9583537677dd7a0205f772f4ecb562d49c81d50d

Pushed by haftandilian@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6530292adcee Remove `customWindows[...]` methods. r=mac-reviewers,bradwerth

https://hg.mozilla.org/mozilla-central/rev/6530292adcee

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Hello!
Reproduced the issue with Firefox 88.0a1 (20210226214501) and full-screen-api.macos-native-full-screen:true on macOS M1 mini 11.2.2 and macOS 10.15.

I can confirm that the issue is verified fixed with Firefox 88.0a1 (20210303215027) on macOS M1 mini 11.2.2 and macOS 10.15. The fake grey bar is no longer displayed when following comment 0 steps and there is also a transition animation to fullscreen.

However, I saw that browser web content does not have a smooth transition when entering/exiting fullscreen. I did a screen recording with the issue for a better understanding: link. This happens with full-screen-api.macos-native-full-screen:false as well. Should we open another bug for this or there is one already open? Thank you!

Thanks Alexandru! For the transition, I'm not aware of any open bug so I suggest filing a new one.

I opened bug 1696428. Closing this as verified per comment 18. Thank you!

Status: RESOLVED → VERIFIED
status-firefox88: fixed → verified
See Also: → 1696428
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: