Closed Bug 1633143 Opened 3 months ago Closed 3 months ago

Update urlbarBindings for Services and Observers

Categories

(SeaMonkey :: Autocomplete, task)

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.75
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

(Whiteboard: SM2.53.3)

Attachments

(3 files)

At the moment urlbarBindings.xml:

  • is not making full use of Services and there is some tidying up that can be done
  • is using field observers and that can be switched to observe methods
  • is not initialising search service asynchronously in some places
Attached patch Services changesSplinter Review

This patch:

  • Switches to use Services.* where possible
  • Observes against "browser.urlbar." pref branch in main urlbar binding which simplifies some of the code
  • As autocomplete-result-popup binding's updatePref method only deals with browser.urlbar.showSearch, rename that method and simplify it and its callers.
Attachment #9143360 - Flags: review?(frgrahl)
Attachment #9143360 - Flags: approval-comm-release?
Attachment #9143360 - Flags: approval-comm-esr60?

This patch switches to use observe method than m*Observer fields for the bindings

Attachment #9143362 - Flags: review?(frgrahl)
Attachment #9143362 - Flags: approval-comm-release?
Attachment #9143362 - Flags: approval-comm-esr60?
Attached patch Search initSplinter Review

This patch:

  • Adds an onInitComplete method and adds nsIBrowserSearchInitObserver implementation.
  • Changes relevant updateEngines calls to do a search init

I've tested all 3 patches on latest 2.53.3, as far as I can see not all updateEngines calls need to be changed.

Attachment #9143366 - Flags: review?(frgrahl)
Attachment #9143366 - Flags: approval-comm-release?
Attachment #9143366 - Flags: approval-comm-esr60?
Comment on attachment 9143360 [details] [diff] [review]
Services changes

LGTM
Attachment #9143360 - Flags: review?(frgrahl)
Attachment #9143360 - Flags: review+
Attachment #9143360 - Flags: approval-comm-release?
Attachment #9143360 - Flags: approval-comm-release+
Attachment #9143360 - Flags: approval-comm-esr60?
Attachment #9143360 - Flags: approval-comm-esr60+
Comment on attachment 9143362 [details] [diff] [review]
Switch to observe method

LGTM
Attachment #9143362 - Flags: review?(frgrahl)
Attachment #9143362 - Flags: review+
Attachment #9143362 - Flags: approval-comm-release?
Attachment #9143362 - Flags: approval-comm-release+
Attachment #9143362 - Flags: approval-comm-esr60?
Attachment #9143362 - Flags: approval-comm-esr60+
Comment on attachment 9143366 [details] [diff] [review]
Search init

LGTM
Attachment #9143366 - Flags: review?(frgrahl)
Attachment #9143366 - Flags: review+
Attachment #9143366 - Flags: approval-comm-release?
Attachment #9143366 - Flags: approval-comm-release+
Attachment #9143366 - Flags: approval-comm-esr60?
Attachment #9143366 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/2b7fabf7b6f7
Update urlbarBindings for Services and Observers - Services part. r=frg
https://hg.mozilla.org/comm-central/rev/b667fd22d4fb
Update urlbarBindings for Services and Observers - switch to observe method part. r=frg
https://hg.mozilla.org/comm-central/rev/de42d117bf8a
Update urlbarBindings for Services and Observers - search init part. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Whiteboard: SM2.53.3

Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/4fa732d9b44e060fdf4044f871b6bffa535f9cbc
Update urlbarBindings for Services and Observers - Services part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c2a59922dc6c354f0e746f790e97133d5393a85a
Update urlbarBindings for Services and Observers - switch to observe method part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a84d228a1831923f26b0b535b67054b2dca8818c
Update urlbarBindings for Services and Observers - search init part. r=frg a=frg

You need to log in before you can comment on or make changes to this bug.