Update urlbarBindings for Services and Observers
Categories
(SeaMonkey :: Autocomplete, task)
Tracking
(seamonkey2.49esr wontfix, seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.3)
Attachments
(3 files)
|
11.47 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
7.21 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
4.05 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
At the moment urlbarBindings.xml:
- is not making full use of Services and there is some tidying up that can be done
- is using field observers and that can be switched to observe methods
- is not initialising search service asynchronously in some places
This patch:
- Switches to use Services.* where possible
- Observes against "browser.urlbar." pref branch in main urlbar binding which simplifies some of the code
- As autocomplete-result-popup binding's updatePref method only deals with browser.urlbar.showSearch, rename that method and simplify it and its callers.
This patch switches to use observe method than m*Observer fields for the bindings
This patch:
- Adds an onInitComplete method and adds nsIBrowserSearchInitObserver implementation.
- Changes relevant updateEngines calls to do a search init
I've tested all 3 patches on latest 2.53.3, as far as I can see not all updateEngines calls need to be changed.
|
||
Comment 4•4 years ago
|
||
Comment on attachment 9143360 [details] [diff] [review] Services changes LGTM
|
|
||
Comment 5•4 years ago
|
||
Comment on attachment 9143362 [details] [diff] [review] Switch to observe method LGTM
|
|
||
Comment 6•4 years ago
|
||
Comment on attachment 9143366 [details] [diff] [review] Search init LGTM
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/2b7fabf7b6f7
Update urlbarBindings for Services and Observers - Services part. r=frg
https://hg.mozilla.org/comm-central/rev/b667fd22d4fb
Update urlbarBindings for Services and Observers - switch to observe method part. r=frg
https://hg.mozilla.org/comm-central/rev/de42d117bf8a
Update urlbarBindings for Services and Observers - search init part. r=frg
|
|
||
Updated•4 years ago
|
|
|
||
Comment 8•4 years ago
|
||
Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/4fa732d9b44e060fdf4044f871b6bffa535f9cbc
Update urlbarBindings for Services and Observers - Services part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c2a59922dc6c354f0e746f790e97133d5393a85a
Update urlbarBindings for Services and Observers - switch to observe method part. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a84d228a1831923f26b0b535b67054b2dca8818c
Update urlbarBindings for Services and Observers - search init part. r=frg a=frg
Description
•