1633291 - Clicking on the edge of the overflow/menu button when its menu is opened reopens it immediately

Status: NEW

(Firefox :: Toolbars and Customization, defect, P3)

Description

[ariasuni]

STR:

1. Maximize Firefox (assuming no panel/taskbar on the right of the screen)
2. Put the cursor on the «hamburger» button, as far far to the right as possible
3. Click one time to open the menu
4. Click a second time to close the menu

When doing that, the menu closes and reopens immediately.

• It’s possible to reproduce with overflow button not with others toolbar buttons
• It seems to happen on every edge (except bottom because then the menu is over it)

Comment 1

[:Gijs (he/him)]

Doesn't happen on Windows or mac, so probably related to disabling the panel animations. I wonder if this is a regression.

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #1)

Doesn't happen on Windows or mac, so probably related to disabling the panel animations.

Yeah, flipping xul.panel-animations.enabled on Linux appears to fix this.

Comment 3

[Dão Gottwald [:dao]]

Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f78d5947333422ab09ec23e3dab0d48538c9d6ad&tochange=9f8b3fc384ae6fe8053b087548c57020a55f00fd

Bug 1033395 seems like an obvious candidate at first glance.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #3)

Bug 1033395 seems like an obvious candidate at first glance.

The change in PanelUI._getPanelAnchor caused this: https://hg.mozilla.org/mozilla-central/rev/e2129917e3d5#l1.33

Comment 5

[:Gijs (he/him)]

Hm, though I can't reproduce on Windows with prefers reduced motion and the panel pref flipped - can you?

Comment 6

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #5)

Hm, though I can't reproduce on Windows with prefers reduced motion and the panel pref flipped - can you?

No, I can't. There's Windows-specific code called from nsXULPopupManager::Rollup but that shouldn't apply here if I read it correctly, so not sure what's going on: https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/layout/xul/nsMenuPopupFrame.cpp#1819-1830

Comment 7

[ariasuni]

I’m also able to reproduce with the overflow button, by clicking on the edge or (visually) slightly outside of the button.
I use Firefox 89.0b14 (64 bits) on Linux.