shutdownhtml is broken

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Bugzilla-General
--
blocker
RESOLVED FIXED
16 years ago
5 years ago

People

(Reporter: bbaetz, Assigned: gerv)

Tracking

({regression})

2.17
Bugzilla 2.18
x86
Linux
regression

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
The shutdownhtml code in CGI.pl processes message.html.tmpl directly, so it
wasn't caught in the greps for the message i18n'ing.

Currently setting shutdownhtml fails with the error:

"You are using Bugzilla's error-reporting functions incorrectly. You passed in
the string 'shutdown!'. The correct use is to pass in a tag, and define that tag
in the file messages.html.tmpl.

If you are a Bugzilla end-user seeing this message, please save this page and
send it to bbaetz@localhost."
(Reporter)

Updated

16 years ago
Keywords: regression
Target Milestone: --- → Bugzilla 2.18
(Assignee)

Comment 1

16 years ago
Created attachment 95892 [details] [diff] [review]
Patch v.1

How right you are. And, of course, this is exactly the sort of thing that the
error message you saw was meant to catch :-)

Review?

Gerv
(Reporter)

Comment 2

16 years ago
Comment on attachment 95892 [details] [diff] [review]
Patch v.1

works.

r=bbaetz x2
Attachment #95892 - Flags: review+
(Assignee)

Comment 3

16 years ago
Checked in.

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.170; previous revision: 1.169
done
Checking in template/en/default/global/messages.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v
 <--  messages.html.tmpl
new revision: 1.6; previous revision: 1.5
done

Gerv
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.