Closed Bug 1633310 Opened 1 year ago Closed 1 year ago

Don't use shouldLoadURI for process switching away from preloaded browser process

Categories

(Core :: DOM: Networking, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

We currently return false from shouldLoadURI when we the current uri is about:newtab (and it's the only entry in session history), under the assumption that this "web" process is likely a preloaded browser process.

I think this is fairly rare now, since about:newtab is usually in the privileged content process, but we disable this pref on ASAN builds.

This caused a failure with parent-initiated loads, where we initiated the load speculatively in the parent, but then the content process cancelled it (due to shouldLoadURI being false), and then started it again in another process. The test (browser_google_behavior) is using waitForDocLoadAndStopIt to cancel loads before they try to hit the network (and assert), but this fails to catch the second load.

We're trying to move away from using shouldLoadURI for process switches (since it can't handle POST data, and it's nicer to have everything rely on DocumentChannel), so fixing this seems worthwhile (rather than modifying the test to work around it).

Note that when about:newtab is loaded in the privileged content process, we don't need any special case handling since normal URIs will compute a different remote type and be processed switched.

It appears that we currently don't do these switches if there is POST data, so maybe we could just stop doing them entirely, and relying on the privileged content process to be enabled for all configurations we care about?

Priority: -- → P3
Whiteboard: [necko-triaged]
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3dcd50f429d9
Don't do pre-load shouldLoadURI process switches for leaving about:newtab in the web process. r=nika,mconley
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Regressions: 1634339
You need to log in before you can comment on or make changes to this bug.