1633315 - sendRemoveListener on closed conduit errors spams the console

Status: NEW

(WebExtensions :: General, defect, P3)

Description

[kernp25]

Attachment: firefox_MBxsHTOXxL.png

I know, that it is expected, that it should throw the error to the console, but it really spams the console with this error: sendRemoveListener on closed conduit simple-translate@sienori.549755894884

I also see one time in console: sendAddListener on closed conduit simple-translate@sienori.549755894554

It seems to happen often with this add-on installed: https://addons.mozilla.org/firefox/addon/simple-translate/

Comment 1

[kernp25]

Attachment: firefox_SKYWDGguwr.png

Comment 2

[kernp25]

My Browser Version: 75.0 (64-Bit)

Comment 3

[Alex Cornestean]

Hello,

I have managed to reproduce the console error you encountered on the latest Nightly (77.0a1/20200429215539), Beta (76.0/20200429185419) and Release (75.0/20200403170909) under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS, however, not during normal usage of the add-on.

To reproduce the error I’ve employed the following STR:

1. Install the extension
2. Go to about:debugging and access the add-on console via “Inspect”
3. On the “Console” tab, refresh the page by pressing F5
   Note: Each press of F5 will produce a new set of the same error (the number after the add-on id changes with each refresh)

Are you doing anything in particular for this add-on to spam the console with the error or just normal usage of the add-on functions?

Comment 4

[kernp25]

(In reply to Alex Cornestean from comment #3)

Are you doing anything in particular for this add-on to spam the console with the error or just normal usage of the add-on functions?

This add-on runs in the background and i'm using it sometimes.

Maybe there is a bug in the add-on itself?

For example.

Comment 5

[kkapsner]

I'm able to reproduce the scenario from Alex with many extensions (µBlock, decentraleyes, NoScript to name a few).

Comment 6

[Sienori]

Attachment: Minimal add-on to reproduce sendRemoveListener on closed conduit errors

I have successfully reproduced this error.
The following listeners in the background script causes the error.

browser.storage.onChanged.addListener(() => {});
browser.contextMenus.onClicked.addListener(() => {});

I don't know how the developer can resolve this error.

Comment 7

[kernp25]

Attachment: ER13Go7H4p.mp4

Tested with uBlock Origin.

Comment 8

[kernp25]

Is this normal, that if you open the extension popup and then closes it, it does throw the error (every time)?

Comment 9

[kernp25]

Can you confirm, that open and closing the extension popup (uBlock Origin) will throw the error?

Comment 10

[Alex Cornestean]

Hello,

I can confirm the behavior stated in Comment 9 by kernp25.

Tested with uBlock Origin on the latest Nightly (78.0a1/20200504205324), Beta (77.0b1/20200504222419) and Release (75.0/20200403170909) under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS.

Closing and opening the extension’s popup will throw the mentioned error.

Comment 11

[Rob Wu [:robwu]]

The error message is not actionable, so we should remove it from the console.

I'm bumping the priority because it is not only logspam, it can also interfere with actual internals. As seen in bug 1640866, this bug can interrupt the cleanup of internals. Bad things could happen...

Comment 12

[Luke]

Any progress on this?

Comment 13

[Rob Wu [:robwu]]

This is an unassigned bug, so safe to say that there is no progress.

Comment 14

[alexandersh]

(In reply to kernp25 from comment #7)

Created attachment 9145190 [details]
ER13Go7H4p.mp4

Tested with uBlock Origin.

hi.
Did you find the reason of such behavior?

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 11 votes.
:mixedpuppy, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 16

[Kazumasa Hasegawa (Kazz)]

When testing my extension with Event Pages ("persistent": false ), this error is logged each time the page is idle.
It is very annoying.

Comment 18

[Frank Buss]

Any news on this bug? I get the message as well for my plugin, interestingly only after some time, about 20 seconds after Thunderbird start.

This is a serious bug for me, because sometimes my plugin stops working after it. I guess this one consequence of the "bad things" mentioned earlier. Here is a simplified version of my plugin to demonstrate the problem:

console.log("add on");

window.onload = function() {
  console.log("on load");
  browser.menus.remove("foobar_ctxVerifyAtt");

  browser.menus.create({
    id: "foobar_ctxVerifyAtt",
    title: "test",
    contexts: ["message_attachments"],
  });
}

browser.menus.onClicked.addListener(async (info, tab) => {
  if (info.menuItemId === "foobar_ctxVerifyAtt") {
      console.log("on verify");
  }
});

It adds a context menu to file attachments. I can click on the context menu one time and see the "on verify" log message. After 20 seconds, I see the "sendRemoveListener on closed conduit" message. Sometimes I can click on the menu again and it works. But then when the message appears again, the add-on doesn't work anymore. The menu is still there, but I don't see the "on verify" message, when I click on it. Sometimes I also get the message "TypeError: linkedBrowser is undefined".

Tested with Thunderbird 115.12.2 on Windows.

Comment 19

[Rob Wu [:robwu]]

(In reply to Frank Buss from comment #18)

Any news on this bug? I get the message as well for my plugin, interestingly only after some time, about 20 seconds after Thunderbird start.

This is a serious bug for me, because sometimes my plugin stops working after it. I guess this one consequence of the "bad things" mentioned earlier.

The error message itself is probably a symptom rather than the root cause of your issue. I recently fixed two issues that can result in the background script becoming non-responsive to events, at bug 1905153 amd bug 1905505. Detailed write-ups are included that can help with evaluating whether they could have affected you.

The error message itself is often harmless, and more frequently triggered with event pages because that context is closed more frequently, similar to the logspam from bug 1447806.

Sometimes I also get the message "TypeError: linkedBrowser is undefined".

The error message without stack trace is not actionable, because the error is quite generic.

Comment 20

[Joseph DeVore]

I am having the same issue, but with a different Firefox addon.
https://addons.mozilla.org/en-US/firefox/addon/download-manager/
because the default Firefox download manager sucks.
tested on the latest Firefox release channel build, v133.0.3
I get the error anytime I clock on the download manager icon to bring up its window.

I was wondering if I should have started my own bug report?
console log stack trace I think as follows..

sendRemoveListener on closed conduit [e-mail].549755844825 ConduitsChild.sys.mjs:122:13
_send resource://gre/modules/ConduitsChild.sys.mjs:122
removeListener resource://gre/modules/ExtensionChild.sys.mjs:688
removeListener resource://gre/modules/ExtensionChild.sys.mjs:944
register chrome://extensions/content/child/ext-storage.js:165
removeListener resource://gre/modules/ExtensionCommon.sys.mjs:2980
revoke resource://gre/modules/ExtensionCommon.sys.mjs:3002
close resource://gre/modules/ExtensionCommon.sys.mjs:3007
unload resource://gre/modules/ExtensionCommon.sys.mjs:1038
unload resource://gre/modules/ExtensionPageChild.sys.mjs:280
unload resource://gre/modules/ExtensionPageChild.sys.mjs:323
destroyExtensionContext resource://gre/modules/ExtensionPageChild.sys.mjs:495
observe resource://gre/modules/ExtensionPageChild.sys.mjs:396

Comment 21

[Giorgio Maone [:ma1]]

This affects the Tor Browser by default, much more so now that NoScript has switched to an event page.