163334 - remove old nav4rounding pref

Status: RESOLVED FIXED

Description

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

We should remove the old nav4rounding pref.  It's implemented on Windows-only,
has no UI, and was really just a transitional thing.  See bug 159332.

Comment 1

[Daniel Kraft]

Created attachment 169632 [details] [diff] [review]
Removes nav4round-Pref

I think this should remove all nav4pref code. (Or, you could say, I'm sure it
removes some of it).
Mozilla with this patch applied builds, and I'm currently submitting this
attachment with it.

Comment 2

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Comment on attachment 169632 [details] [diff] [review]
Removes nav4round-Pref

You should also remove the entire PrefChanged function, kPrefCID, and the
#include of nsIPref.h.	(But with those changes added I think it's fine.)

Comment 3

[Daniel Kraft]

Created attachment 169639 [details] [diff] [review]
Fixed Patch

Now without the whole PrefChanged-method (of course, if no RegisterCallback is
there anymore, this method is superfluous...)

Comment 4

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Comment on attachment 169639 [details] [diff] [review]
Fixed Patch

>   float app2dev, app2twip, scale;

remove app2twip and scale as well and r=dbaron

Comment 5

[Daniel Kraft]

Created attachment 169640 [details] [diff] [review]
Removed locals

Removed those local variables, too.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 169640 [details] [diff] [review]
Removed locals

r=jst

Comment 7

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Daniel, I assume you want this checked in once the tree reopens?

Comment 8

[Daniel Kraft]

Oh yes, please.

Comment 9

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Fixed for 1.8b.