remove old nav4rounding pref

RESOLVED FIXED in Future

Status

()

defect
P2
minor
RESOLVED FIXED
17 years ago
15 years ago

People

(Reporter: dbaron, Assigned: domob)

Tracking

Trunk
Future
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [whitebox][good first bug])

Attachments

(1 attachment, 2 obsolete attachments)

We should remove the old nav4rounding pref.  It's implemented on Windows-only,
has no UI, and was really just a transitional thing.  See bug 159332.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Future

Updated

17 years ago
Whiteboard: [dev notes]

Updated

17 years ago
Whiteboard: [dev notes] → [whitebox]
Whiteboard: [whitebox] → [whitebox][good first bug]
Assignee

Comment 1

15 years ago
Posted patch Removes nav4round-Pref (obsolete) β€” β€” Splinter Review
I think this should remove all nav4pref code. (Or, you could say, I'm sure it
removes some of it).
Mozilla with this patch applied builds, and I'm currently submitting this
attachment with it.
Attachment #169632 - Flags: review?(dbaron)
Comment on attachment 169632 [details] [diff] [review]
Removes nav4round-Pref

You should also remove the entire PrefChanged function, kPrefCID, and the
#include of nsIPref.h.	(But with those changes added I think it's fine.)
Attachment #169632 - Flags: review?(dbaron) → review-
Assignee

Comment 3

15 years ago
Posted patch Fixed Patch (obsolete) β€” β€” Splinter Review
Now without the whole PrefChanged-method (of course, if no RegisterCallback is
there anymore, this method is superfluous...)
Attachment #169632 - Attachment is obsolete: true
Attachment #169639 - Flags: review?(dbaron)
Comment on attachment 169639 [details] [diff] [review]
Fixed Patch

>   float app2dev, app2twip, scale;

remove app2twip and scale as well and r=dbaron
Attachment #169639 - Flags: review?(dbaron) → review+
Assignee

Comment 5

15 years ago
Posted patch Removed locals β€” β€” Splinter Review
Removed those local variables, too.
Attachment #169639 - Attachment is obsolete: true
Attachment #169640 - Flags: review?(dbaron)
Attachment #169640 - Flags: review?(dbaron) → review+
Assignee

Updated

15 years ago
Attachment #169640 - Flags: superreview?(jst)
Comment on attachment 169640 [details] [diff] [review]
Removed locals

r=jst
Attachment #169640 - Flags: superreview?(jst) → superreview+
Daniel, I assume you want this checked in once the tree reopens?
Assignee

Comment 8

15 years ago
Oh yes, please.
Assignee: dbaron → d
Status: ASSIGNED → NEW
Fixed for 1.8b.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.